linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Stephen Neuendorffer" <stephen.neuendorffer@xilinx.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Xilinx: framebuffer: add compatibility for ml507 dvi core.
Date: Mon, 12 May 2008 12:30:25 -0600	[thread overview]
Message-ID: <fa686aa40805121130n53b14a8fye692e06616dc3bc7@mail.gmail.com> (raw)
In-Reply-To: <20080512173130.0D747181804D@mail89-sin.bigfish.com>

On Mon, May 12, 2008 at 11:31 AM, Stephen Neuendorffer
<stephen.neuendorffer@xilinx.com> wrote:
>
>  Not easily.  As we discussed before, there is nowhere that really
>  specifies this information.  In some cases I've modified the device tree
>  generator to understand what is backward compatible, as with ns16550,
>  but for other cores it makes more sense to me to put this compatibility
>  information with the driver if it has to be anywhere.

The main concern is that the driver will balloon with data which
impacts the load size for all builds that compile it in.  It also
reduces the impact of minor modifications of the IP cores (ie. the
kernel still works when I've up-revved an ip core from 1.00a to
1.00b.)

I understand that it is hard within the EDK TCL scripts context, but
this is exactly what compatible is designed for and I don't think
continually adding more versions to the list is sustainable in the
long term.  The more I think about it, the more I'm uneasy about this
approach.

For the time being, I'm going to resist merging this change into my
tree, but I'll keep it in my "don't forget about this" list.  It's not
going into .26 anyway, so there is no time pressure.  Later, when
we're closer to the .27 merge window, I'll look at it again, but I
really would prefer to find a way to add to the compatible list.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2008-05-12 18:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 17:59 [PATCH] Xilinx: framebuffer: add compatibility for ml507 dvi core Stephen Neuendorffer
2008-05-12 14:24 ` Grant Likely
2008-05-12 17:31   ` Stephen Neuendorffer
2008-05-12 18:30     ` Grant Likely [this message]
2008-05-12 19:10       ` Stephen Neuendorffer
2008-05-12 19:46         ` Grant Likely
2008-05-12 19:59           ` Stephen Neuendorffer
2008-05-14 15:35             ` Grant Likely
2008-05-14 18:03               ` Stephen Neuendorffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40805121130n53b14a8fye692e06616dc3bc7@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=stephen.neuendorffer@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).