linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Remi Machet" <rmachet@slac.stanford.edu>
Cc: Linux PPC <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 1/5] powerpc: DTS file for the C2K
Date: Fri, 16 May 2008 11:48:04 -0600	[thread overview]
Message-ID: <fa686aa40805161048s3a9d9959v205b0fabd66a751d@mail.gmail.com> (raw)
In-Reply-To: <1210958434.14306.9.camel@pcds-ts102.slac.stanford.edu>

On Fri, May 16, 2008 at 11:20 AM, Remi Machet <rmachet@slac.stanford.edu> wrote:
> On Fri, 2008-05-16 at 11:53 +1000, David Gibson wrote:
>> This is a suspicious looking use of cell-index, though again this
>> could be a problem in the binding rather than your tree per se.
>> cell-index should *only* be present if it's used to index into some
>> shared resource register.
> This is actually my mistake: I use this property in
> arch/powerpc/boot/c2k.c to differentiate the 2 PCI buses. What property
> should I use instead ? I could detect the PCI bus # based on the reg
> property (memory base can change but not the registers address), what do
> you think ?

Use either the base address (a little ugly) or create a couple of
properties under the aliases node with the path to the two PCI busses
(cleaner, but a slight bit more work).

ie:

aliases {
       pci-bus1 = &pci1;
       pci-bus2 = &pci2;
};

Cheers,
g.

>
> Remi
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2008-05-16 17:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16  0:22 [PATCH 1/5] powerpc: DTS file for the C2K Remi Machet
2008-05-16  1:53 ` David Gibson
2008-05-16 17:20   ` Remi Machet
2008-05-16 17:48     ` Grant Likely [this message]
2008-05-19  0:44     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40805161048s3a9d9959v205b0fabd66a751d@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=rmachet@slac.stanford.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).