From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Emil Medve" <Emilian.Medve@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Add the PC speaker only when requested so
Date: Thu, 22 May 2008 17:27:45 -0600 [thread overview]
Message-ID: <fa686aa40805221627u4c4580bane16f3c3e23c8e9f5@mail.gmail.com> (raw)
In-Reply-To: <1211496016-30311-1-git-send-email-Emilian.Medve@Freescale.com>
On Thu, May 22, 2008 at 4:40 PM, Emil Medve <Emilian.Medve@freescale.com> wrote:
> This will cause this minor boot-time debugging error message to go away:
>
> [ 1.316451] calling add_pcspkr+0x0/0x84
> [ 1.316478] initcall add_pcspkr+0x0/0x84 returned -19 after 0 msecs
What situation are you hitting this in? The code should only run if
there is a "pnpPNP,100" compatible node in the device tree.
Also, where is CONFIG_PCSPKR_PLATFORM defined? I don't see it
anywhere in powerpc code and only a reference to it in an x86
Makefile. As it stands, it looks like this patch unconditionally
disables the pcspkr code.
Cheers,
g.
>
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
> ---
>
>> scripts/checkpatch.pl 0001--POWERPC-Add-the-PC-speaker-only-when-requested-so.patch
> total: 0 errors, 0 warnings, 14 lines checked
>
> 0001--POWERPC-Add-the-PC-speaker-only-when-requested-so.patch has no obvious style problems and is ready for submission.
>
> arch/powerpc/kernel/setup-common.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index db540ea..61a3f41 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -500,6 +500,7 @@ void __init smp_setup_cpu_sibling_map(void)
> }
> #endif /* CONFIG_SMP */
>
> +#ifdef CONFIG_PCSPKR_PLATFORM
> static __init int add_pcspkr(void)
> {
> struct device_node *np;
> @@ -522,6 +523,7 @@ static __init int add_pcspkr(void)
> return ret;
> }
> device_initcall(add_pcspkr);
> +#endif /* CONFIG_PCSPKR_PLATFORM */
>
> void probe_machine(void)
> {
> --
> 1.5.5.GIT
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-05-22 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 22:40 [PATCH] [POWERPC] Add the PC speaker only when requested so Emil Medve
2008-05-22 23:27 ` Grant Likely [this message]
2008-05-23 3:34 ` Kumar Gala
2008-05-23 4:44 ` Grant Likely
2008-05-23 12:59 ` Medve Emilian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40805221627u4c4580bane16f3c3e23c8e9f5@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=Emilian.Medve@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).