From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.245]) by ozlabs.org (Postfix) with ESMTP id 274BFDE1A7 for ; Sun, 25 May 2008 02:50:53 +1000 (EST) Received: by an-out-0708.google.com with SMTP id c34so280214anc.78 for ; Sat, 24 May 2008 09:50:52 -0700 (PDT) Message-ID: Date: Sat, 24 May 2008 10:50:52 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "David Brownell" Subject: Re: [PATCH 3/4] spi: Add OF binding support for SPI busses In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> <20080516193613.28030.13950.stgit@trillian.secretlab.ca> <20080521151928.GA28857@polina.dev.rtsoft.ru> <200805221905.32288.david-b@pacbell.net> Cc: fabrizio.garetto@gmail.com, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, May 24, 2008 at 12:26 AM, Grant Likely wrote: > On Thu, May 22, 2008 at 8:05 PM, David Brownell wrote: >> On Wednesday 21 May 2008, Anton Vorontsov wrote: >>> > +++ b/drivers/spi/spi_of.c >>> >>> I think better placement for this is drivers/of, no? >> >> Yes please. > > Okay, I wasn't sure. Will do. I'm having second thoughts about this. I think this code is more SPI centric than it is OF centric. ie. it is usable by all spi masters in an OF enabled system, but it is not usable by all OF devices in an SPI enabled system. Or, in other words; it adds OF support to SPI, not the other way around. I think drivers/spi is the right place for this to live. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.