From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Scott Wood" <scottwood@freescale.com>
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] phylib: Don't allow core of phylib to build as a module
Date: Fri, 6 Jun 2008 09:19:50 -0600 [thread overview]
Message-ID: <fa686aa40806060819t75c1c0b0h303ff37d387b2373@mail.gmail.com> (raw)
In-Reply-To: <48448020.5020407@freescale.com>
On Mon, Jun 2, 2008 at 5:20 PM, Scott Wood <scottwood@freescale.com> wrote:
> Kumar Gala wrote:
>> I think we'd be better off with a small stub that is always built into the
>> kernel for phy_read/phy_write, etc or the function pointer indirection
>> mechanism.
>
> And then instead of build failures, you'd get a silent runtime failure to
> apply the workaround if phylib is built as a module.
Indeed; I vote for the build failure over the silent runtime failure.
If a platform needs it and does not select it, then the platform is
broken and it is a bug.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-06-06 15:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 15:58 [PATCH] phylib: Don't allow core of phylib to build as a module Kumar Gala
2008-06-02 16:03 ` Jeff Garzik
2008-06-02 16:25 ` Kumar Gala
2008-06-02 16:32 ` Scott Wood
2008-06-02 16:39 ` Jeff Garzik
2008-06-02 19:19 ` Kumar Gala
2008-06-02 20:29 ` Jeff Garzik
2008-06-02 23:06 ` Kumar Gala
2008-06-02 19:30 ` Kumar Gala
2008-06-02 19:44 ` Andy Fleming
2008-06-02 20:30 ` Jeff Garzik
2008-06-02 23:07 ` Kumar Gala
2008-06-02 23:20 ` Scott Wood
2008-06-03 14:47 ` [RFC] Make board force selection of PHYLIB Kumar Gala
2008-06-03 15:10 ` Scott Wood
2008-06-03 15:14 ` Kumar Gala
2008-06-03 15:18 ` Scott Wood
2008-06-03 15:31 ` Kumar Gala
2008-06-03 15:36 ` Scott Wood
2008-06-03 15:40 ` Kumar Gala
2008-06-03 15:56 ` Scott Wood
2008-06-03 18:07 ` Andy Fleming
2008-06-03 17:00 ` Adrian Bunk
2008-06-03 18:11 ` Andy Fleming
2008-06-03 18:23 ` Kumar Gala
2008-06-06 15:19 ` Grant Likely [this message]
2008-06-02 16:54 ` [PATCH] phylib: Don't allow core of phylib to build as a module Adrian Bunk
2008-06-02 19:24 ` Kumar Gala
2008-06-06 15:40 ` [PATCH] [POWERPC] 85xx: MPC85xx MDS - Unconditionally select PHYLIB for board fixups Kumar Gala
2008-06-06 17:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40806060819t75c1c0b0h303ff37d387b2373@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).