linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Juergen Beisert" <jbe@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Comments on device tree for pcm030
Date: Tue, 10 Jun 2008 07:26:07 -0600	[thread overview]
Message-ID: <fa686aa40806100626t14ee44fnc1108426b73fc7fd@mail.gmail.com> (raw)
In-Reply-To: <200806101105.15080.jbe@pengutronix.de>

On Tue, Jun 10, 2008 at 3:05 AM, Juergen Beisert <jbe@pengutronix.de> wrote:
> Maybe everything in this small piece of my dts is wrong. But I don't know how
> the correct way is. All I want is to define a 32MiB flash at the end if the
> address space of my MPC5200B based system.
>
>        [...]
>        lpb@fe000000 {
>                model = "fsl,lpb";
>                compatible = "fsl,lpb";
>                ranges = <0x0 0xfe000000 0x02000000>;

- You need #address-cells and #size-cells in bus nodes.
#address-cells should be <2> in fsl,lpb nodes.  Your ranges property
is broken due to the missing #address/size-cells.

>                flash@0 {
>                        compatible = "cfi-flash";
>                        reg = <0x00000000 0x02000000>;

- since address cells will be '2', you need 2 cells to describe the
base address here; first cell is the chip select, second cell is the
address offset off that base address.

>                        bank-width = <4>;
>                };
>        };
>
> The dtc gives me the follwing output:
>
> Warning (reg_format): "reg" property in /lpb@fe000000/flash@0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (ranges_format): "ranges" property in /lpb@fe000000 has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /lpb@fe000000/flash@0
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /lpb@fe000000/flash@0
>
> What does it mean?
>
> At runtime I get:
>
> [...]
> of-flash fe000000.flash: of_flash device: fe000000-ffffffff
> CFI: Found no fe000000.flash device at location zero
> of-flash fe000000.flash: do_map_probe() failed
> [...]
>
> What's going wrong? Any hint?
>
> Regards,
> Juergen
>
> --
> Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
>  Pengutronix - Linux Solutions for Science and Industry
>     Handelsregister: Amtsgericht Hildesheim, HRA 2686
>          Vertretung Sued/Muenchen, Germany
>   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2008-06-10 13:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08 19:08 Comments on device tree for pcm030 Jon Smirl
2008-06-08 23:28 ` Grant Likely
2008-06-09  7:56   ` Juergen Beisert
2008-06-09 12:37     ` Jon Smirl
2008-06-09 13:05       ` Juergen Beisert
2008-06-09 12:41     ` Jon Smirl
2008-06-09 13:57     ` Grant Likely
2008-06-09  9:13 ` Sascha Hauer
2008-06-09 21:00   ` Robert Schwebel
2008-06-09 16:31 ` Juergen Beisert
2008-06-09 21:30   ` Jon Smirl
2008-06-10  8:20     ` Juergen Beisert
2008-06-10  9:05       ` Juergen Beisert
2008-06-10 13:26         ` Grant Likely [this message]
2008-06-11  4:08           ` Jon Smirl
2008-06-09 21:05 ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40806100626t14ee44fnc1108426b73fc7fd@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=jbe@pengutronix.de \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).