From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.249]) by ozlabs.org (Postfix) with ESMTP id 97815DE028 for ; Wed, 11 Jun 2008 23:30:38 +1000 (EST) Received: by an-out-0708.google.com with SMTP id c34so643896anc.78 for ; Wed, 11 Jun 2008 06:30:36 -0700 (PDT) Message-ID: Date: Wed, 11 Jun 2008 07:30:35 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "David Jander" , linuxppc-dev Subject: Re: [PATCH] prtlvt board support (MPC5121e) added In-Reply-To: <200806111141.16901.david.jander@protonic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <200806101842.36755.david@protonic.nl> <200806111141.16901.david.jander@protonic.nl> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 11, 2008 at 3:41 AM, David Jander wrote: > On Tuesday 10 June 2008 22:37:18 you wrote: >> Thanks for the patch, comments below. >> > --- /dev/null >> > +++ b/arch/powerpc/platforms/512x/prtlvt.c >> >> Looks like you've just duplicated mpc5121_ads.c. You should just add >> your boards name to the mpc5121_ads_probe function. Bonus points if >> you rename the .c file to something more generic. You only need a new >> board file if your board needs something special. > > Well, it looks like mpc5121_ads.c is pretty generic. The MPC5121 is almost > a "motherboard-in-a-chip" type of SoC, so there isn't much board-specific > stuff anywhere. IO-control register setup should be done in the boot-loader. > What should we do about this then? Rename the whole mpc5121_ads stuff to > something more generic? What about calling it "mpc5121_generic.c"? mpc5121_generic.c works for me. > Btw, you posted this to linucppc-dev mailing list, but I think that was a > mistake, since this is clearly an embedded processor, so I removed the CC. Nope, not a mistake. Discussions on embedded stuff is welcome on the linuxppc-dev mailing list. There has been some talk of removing the linuxppc-embedded list entirely. I've added the list back to the to: list. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.