Re: [PATCH 1/2] Added support for PRTLVT based boards (MPC5121)

["Grant Likely" <grant.likely@secretlab.ca>]

On Wed, Jun 11, 2008 at 11:58 AM, Scott Wood <scottwood@freescale.com> wrote:
> David Jander wrote:
>> +config MPC5121_GENERIC
>> +       bool
>> +       default n
>> +
>>  config MPC5121_ADS
>>        bool "Freescale MPC5121E ADS"
>>        depends on PPC_MULTIPLATFORM && PPC32
>>        select DEFAULT_UIMAGE
>>        select PPC_MPC5121
>> +       select MPC5121_GENERIC
>>        help
>>          This option enables support for the MPC5121E ADS board.
>>        default n
>> +
>> +config PRTLVT
>> +       bool "Protonic LVT family of MPC5121 based boards"
>> +       depends on PPC_MULTIPLATFORM && PPC32
>> +       select DEFAULT_UIMAGE
>> +       select PPC_MPC5121
>> +       select MPC5121_GENERIC
>> +       help
>> +         This option enables support for the Protonic LVT family (ZANMCU
>> and VICVT2).
>> +       default n
>
> Can we leave out the "default n" lines?  They're no-ops.
>
> I don't think these configs should depend on an option (PPC_MULTIPLATFORM)
> that is described as "Generic desktop/server/laptop"...

PPC_MULTIPLATFORM may be described poorly, but it is the appropriate
option.  However, it should probably be that the whole 5121 support
Kconfig should depend on MULTIPLATFORM, not individual board ports.
That being said, David is just duplicating what was already done for
the ADS board, so I'm not going to harp on him to change it in this
patch.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.