From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Grant Likely" <grant.likely@secretlab.ca>,
"David Jander" <david.jander@protonic.nl>,
linuxppc-dev@ozlabs.org, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 1/2] Added support for PRTLVT based boards (MPC5121)
Date: Thu, 12 Jun 2008 23:12:24 -0600 [thread overview]
Message-ID: <fa686aa40806122212s50a76750g7181cacb7e161bd0@mail.gmail.com> (raw)
In-Reply-To: <20080613041943.GC29451@yookeroo.seuss>
On Thu, Jun 12, 2008 at 10:19 PM, David Gibson
<david@gibson.dropbear.id.au> wrote:
> On Thu, Jun 12, 2008 at 08:10:47AM -0600, Grant Likely wrote:
> [snip]
>> > + i2ccontrol@1760 {
>> > + compatible = "fsl,mpc5121-i2c-ctrl";
>> > + reg = <0x1760 0x8>;
>> > + };
>> > +
>> > + diu@2100 {
>>
>> (nitpick) There is a recommended practice that says node names should
>> be generic as much as possible, so I think this should probably be
>> video@2100. The compatible value is fine.
>
> If this is a video display device, the recommended generic name is
> "display@XX", not "video@XX".
heh; oops. I should know better and I stand corrected. :-)
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-06-13 5:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 11:44 [PATCH 1/2] Added support for PRTLVT based boards (MPC5121) David Jander
2008-06-12 11:45 ` [PATCH 2/2] Re-added support for FEC on MPC5121 from Freescale LTIB to current head David Jander
2008-06-12 12:12 ` Kumar Gala
2008-06-12 13:36 ` Grant Likely
2008-06-13 9:32 ` David Jander
2008-06-12 13:54 ` Grant Likely
2008-06-12 14:10 ` [PATCH 1/2] Added support for PRTLVT based boards (MPC5121) Grant Likely
2008-06-13 4:19 ` David Gibson
2008-06-13 5:12 ` Grant Likely [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-11 9:43 David Jander
2008-06-11 17:58 ` Scott Wood
2008-06-12 6:20 ` Grant Likely
2008-06-12 6:54 ` David Jander
2008-06-12 13:15 ` Scott Wood
2008-06-12 6:36 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40806122212s50a76750g7181cacb7e161bd0@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=david.jander@protonic.nl \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).