From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Stephen Neuendorffer" <stephen.neuendorffer@xilinx.com>
Cc: linuxppc-dev@ozlabs.org, git <git@xilinx.com>, dwg@au1.ibm.com
Subject: Re: [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.
Date: Sat, 28 Jun 2008 14:33:57 -0600 [thread overview]
Message-ID: <fa686aa40806281333i5ae1833fg561622640b5d3a4e@mail.gmail.com> (raw)
In-Reply-To: <20080606161932.0650C1500054@mail96-sin.bigfish.com>
On Fri, Jun 6, 2008 at 10:16 AM, Stephen Neuendorffer
<stephen.neuendorffer@xilinx.com> wrote:
>
> legacy_serial identifies a valid ns16550 on a simple-bus, but the
> legacy_serial driver doesn't understand the shift and offset flags
> necessary to get it to work, which results in no console.
>
> I think the easiest solution is to change the Kconfig so that
> PPC_UDBG_16550 is only selected based on !XILINX_VIRTEX. I've done this
> in my tree, but I've been swamped with other things at the moment, so I
> haven't verified it.
This is an easy solution, but it is not a good one. Doing so would
break UDBG on other 405 boards when building multiplatform kernels.
It would be better to teach legacy serial about the shift and offset.
Alternately, add code to add_legacy_soc_port() to skip it if the
shift/offset properties are present.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-06-28 20:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 20:47 [PATCH] [POWERPC] Xilinx: add compatibility for IBM coreconnect busses Stephen Neuendorffer
2008-05-07 22:33 ` Grant Likely
2008-05-07 22:38 ` Stephen Neuendorffer
2008-05-08 0:18 ` David Gibson
2008-05-08 2:46 ` Josh Boyer
2008-05-08 3:30 ` David Gibson
2008-05-08 11:16 ` Josh Boyer
2008-05-08 16:15 ` [PATCH] [POWERPC] Xilinx: add compatibility for IBMcoreconnect busses Stephen Neuendorffer
2008-05-08 18:25 ` [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus' Stephen Neuendorffer
2008-05-08 18:27 ` Grant Likely
[not found] ` <1210271125-11559-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-06-03 21:41 ` Stephen Neuendorffer
2008-06-06 15:29 ` Grant Likely
2008-06-06 16:16 ` Stephen Neuendorffer
2008-06-28 20:33 ` Grant Likely [this message]
2008-06-30 3:42 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B615019F061@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-06-30 14:39 ` John Linn
[not found] ` <20080630034548.A10A81750069@mail131-sin.bigfish.com>
2008-06-30 16:34 ` Grant Likely
2008-06-30 16:48 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B6150062A27B7@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-06-30 16:49 ` John Linn
2008-07-01 6:16 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40806281333i5ae1833fg561622640b5d3a4e@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=dwg@au1.ibm.com \
--cc=git@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=stephen.neuendorffer@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).