From: "Grant Likely" <grant.likely@secretlab.ca>
To: "John Rigby" <jrigby@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/8][Version 2] MPC5121 Add generic board support
Date: Sun, 29 Jun 2008 02:01:29 -0600 [thread overview]
Message-ID: <fa686aa40806290101w59e80f48ue7e7ae103993c3fe@mail.gmail.com> (raw)
In-Reply-To: <1214342672-23536-4-git-send-email-jrigby@freescale.com>
On Tue, Jun 24, 2008 at 3:24 PM, John Rigby <jrigby@freescale.com> wrote:
> Move shared code from mpc5121_ads.c to mpc512x_shared.c.
> Add new generic board setup mpc5121_generic.c
>
> Signed-off-by: John Rigby <jrigby@freescale.com>
> ---
> +void __init mpc512x_init_IRQ(void)
> +{
> + struct device_node *np;
> +
> + np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
Along with all my other device-tree conventions comments; you should
really be testing for fsl,mpc5121-ipic here. fsl,ipic is not a good
value for compatible.
g.
next prev parent reply other threads:[~2008-06-29 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 21:24 [PATCH 0/8][Version 2] MPC5121 Updates John Rigby
[not found] ` <1214342672-23536-2-git-send-email-jrigby@freescale.com>
2008-06-24 21:24 ` [PATCH 2/8][Version 2] MPC5121 clock driver John Rigby
2008-06-24 21:24 ` [PATCH 3/8][Version 2] MPC5121 Add generic board support John Rigby
2008-06-24 21:24 ` [PATCH 4/8][Version 2] MPC5121 Add MPC5121ADS cpld support John Rigby
2008-06-24 21:24 ` [PATCH 5/8][Version 2] powerpc: pci config cleanup John Rigby
2008-06-24 21:24 ` [PATCH 6/8][Version 2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c John Rigby
2008-06-24 21:24 ` [PATCH 7/8][Version 2] MPC5121 Add PCI support John Rigby
2008-06-24 21:24 ` [PATCH 8/8][Version 2] MPC5121 Hide pci bridge John Rigby
2008-06-24 21:41 ` Sergei Shtylyov
2008-06-25 17:17 ` [PATCH 6/8][Version 2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c Kumar Gala
2008-06-29 8:01 ` Grant Likely [this message]
2008-06-25 6:31 ` [PATCH 2/8][Version 2] MPC5121 clock driver David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40806290101w59e80f48ue7e7ae103993c3fe@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).