[PATCH] [POWERPC] 52xx: add missing MSCAN FDT nodes for TQM52xx

[PATCH] [POWERPC] 52xx: add missing MSCAN FDT nodes for TQM52xx

[Wolfgang Grandegger]

This patch adds the still missing FDT nodes for the MSCAN devices for
the TQM52xx modules.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 arch/powerpc/boot/dts/tqm5200.dts |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Index: linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
===================================================================
--- linux-2.6-galak.orig/arch/powerpc/boot/dts/tqm5200.dts
+++ linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
@@ -70,6 +70,22 @@
 			fsl,has-wdt;
 		};
 
+		can@900 {
+			compatible = "fsl,mpc5200-mscan";
+			cell-index = <0>;
+			interrupts = <2 17 0>;
+			interrupt-parent = <&mpc5200_pic>;
+			reg = <0x900 0x80>;
+		};
+
+		can@980 {
+			compatible = "fsl,mpc5200-mscan";
+			cell-index = <1>;
+			interrupts = <2 18 0>;
+			interrupt-parent = <&mpc5200_pic>;
+			reg = <0x980 0x80>;
+		};
+
 		gpio@b00 {
 			compatible = "fsl,mpc5200-gpio";
 			reg = <0xb00 0x40>;

Re: [PATCH] [POWERPC] 52xx: add missing MSCAN FDT nodes for TQM52xx

[David Gibson]

On Wed, Jul 02, 2008 at 11:56:40AM +0200, Wolfgang Grandegger wrote:
> This patch adds the still missing FDT nodes for the MSCAN devices for
> the TQM52xx modules.
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> ---
> arch/powerpc/boot/dts/tqm5200.dts |   16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> Index: linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
> ===================================================================
> --- linux-2.6-galak.orig/arch/powerpc/boot/dts/tqm5200.dts
> +++ linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
> @@ -70,6 +70,22 @@
> 			fsl,has-wdt;
> 		};
>
> +		can@900 {
> +			compatible = "fsl,mpc5200-mscan";
> +			cell-index = <0>;

What shared resource are these cell-index values used to index into?
Because cell-index is so freqeuntly misunderstood, I strongly
recommend putting a comment describing this.

> +			interrupts = <2 17 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +			reg = <0x900 0x80>;
> +		};
> +
> +		can@980 {
> +			compatible = "fsl,mpc5200-mscan";
> +			cell-index = <1>;
> +			interrupts = <2 18 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +			reg = <0x980 0x80>;
> +		};
> +
> 		gpio@b00 {
> 			compatible = "fsl,mpc5200-gpio";
> 			reg = <0xb00 0x40>;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH] [POWERPC] 52xx: add missing MSCAN FDT nodes for TQM52xx

[Grant Likely]

On Sun, Jul 6, 2008 at 5:53 PM, David Gibson
<david@gibson.dropbear.id.au> wrote:
> On Wed, Jul 02, 2008 at 11:56:40AM +0200, Wolfgang Grandegger wrote:
>> This patch adds the still missing FDT nodes for the MSCAN devices for
>> the TQM52xx modules.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>> ---
>> arch/powerpc/boot/dts/tqm5200.dts |   16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> Index: linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
>> ===================================================================
>> --- linux-2.6-galak.orig/arch/powerpc/boot/dts/tqm5200.dts
>> +++ linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
>> @@ -70,6 +70,22 @@
>>                       fsl,has-wdt;
>>               };
>>
>> +             can@900 {
>> +                     compatible = "fsl,mpc5200-mscan";
>> +                     cell-index = <0>;
>
> What shared resource are these cell-index values used to index into?
> Because cell-index is so freqeuntly misunderstood, I strongly
> recommend putting a comment describing this.

This is still my fault.  The lite5200.dts which everyone uses as the
example to go by for 5200 board ports still has it, so everyone just
copies it.  I'll look at fixing all of them up.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.