From: "Grant Likely" <grant.likely@secretlab.ca>
To: benh@kernel.crashing.org
Cc: dwg@au1.ibm.com, linuxppc-dev@ozlabs.org, paulus@samba.org,
John Linn <john.linn@xilinx.com>
Subject: Re: [PATCH] [V2] powerpc: legacy_serial: reg-offset & shift aren't used
Date: Mon, 7 Jul 2008 08:24:38 -0600 [thread overview]
Message-ID: <fa686aa40807070724j4b410e9dhfbea2c0c99046e63@mail.gmail.com> (raw)
In-Reply-To: <1215413228.8970.106.camel@pasglop>
On Mon, Jul 7, 2008 at 12:47 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Tue, 2008-07-01 at 10:52 -0700, John Linn wrote:
>> The legacy serial driver does not work with an 8250
>> type UART that uses reg-offset and reg-shift. This
>> change updates the driver so it doesn't find the UART
>> when those properties are present on the UART in the
>> device tree for soc devices.
>
> I have some problems with this patch:
>
> - First if the properties are present but their value match the
> register layout of a standard UART, we will bail out... not nice.
Okay, that can be fixed.
> - Why don't we just implement support for the reg-shift and
> offset instead ?
We can do this, but this patch was simpler for solving the immediate
problem in .26
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2008-07-07 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:52 [PATCH] [V2] powerpc: legacy_serial: reg-offset & shift aren't used John Linn
2008-07-07 6:47 ` Benjamin Herrenschmidt
2008-07-07 11:01 ` Josh Boyer
2008-07-07 22:00 ` Benjamin Herrenschmidt
2008-07-07 14:24 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40807070724j4b410e9dhfbea2c0c99046e63@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=john.linn@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).