From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ag-out-0708.google.com (ag-out-0708.google.com [72.14.246.244]) by ozlabs.org (Postfix) with ESMTP id 181E6DE73E for ; Tue, 8 Jul 2008 00:24:40 +1000 (EST) Received: by ag-out-0708.google.com with SMTP id 8so13150120agc.0 for ; Mon, 07 Jul 2008 07:24:39 -0700 (PDT) Message-ID: Date: Mon, 7 Jul 2008 08:24:38 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: benh@kernel.crashing.org Subject: Re: [PATCH] [V2] powerpc: legacy_serial: reg-offset & shift aren't used In-Reply-To: <1215413228.8970.106.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080701175250.E0BA41CE804D@mail117-va3.bigfish.com> <1215413228.8970.106.camel@pasglop> Cc: dwg@au1.ibm.com, linuxppc-dev@ozlabs.org, paulus@samba.org, John Linn List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jul 7, 2008 at 12:47 AM, Benjamin Herrenschmidt wrote: > On Tue, 2008-07-01 at 10:52 -0700, John Linn wrote: >> The legacy serial driver does not work with an 8250 >> type UART that uses reg-offset and reg-shift. This >> change updates the driver so it doesn't find the UART >> when those properties are present on the UART in the >> device tree for soc devices. > > I have some problems with this patch: > > - First if the properties are present but their value match the > register layout of a standard UART, we will bail out... not nice. Okay, that can be fixed. > - Why don't we just implement support for the reg-shift and > offset instead ? We can do this, but this patch was simpler for solving the immediate problem in .26 g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.