From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Sean MacLennan" <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org, Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH] Fix wrong 'no interrupt' handling in of_i2c
Date: Wed, 16 Jul 2008 16:22:33 -0600 [thread overview]
Message-ID: <fa686aa40807161522h6e20eab1m36c4ed55926652b5@mail.gmail.com> (raw)
In-Reply-To: <20080716181556.2974a1a8@lappy.seanm.ca>
On Wed, Jul 16, 2008 at 4:15 PM, Sean MacLennan <smaclennan@pikatech.com> wrote:
> On Sat, 28 Jun 2008 13:16:16 -0600
> "Grant Likely" <grant.likely@secretlab.ca> wrote:
>
>> On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang
>> <w.sang@pengutronix.de> wrote:
>> > If an I2C device node does not specify an interrupt, the .irq
>> > member of the board_info struct was set to -1. This caused crashes
>> > on following irq_dispose_mappings. Leave it NO_IRQ as returned from
>> > irq_of_parse_and_map. (Suggesting -1 as 'i2c-no-irq' used to be a
>> > bug in linux/i2c.h.)
>> >
>> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
>>
>> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>>
>
> I just hit this while trying to get the at24 driver working. So:
>
> Acked-by: Sean MacLennan <smaclennan@pikatech.com>
Okay, I'll pick this one up.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2008-07-16 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 18:31 [PATCH] Fix wrong 'no interrupt' handling in of_i2c Wolfram Sang
2008-06-28 19:16 ` Grant Likely
2008-07-16 22:15 ` Sean MacLennan
2008-07-16 22:22 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40807161522h6e20eab1m36c4ed55926652b5@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).