Re: [PATCH] powerpc: 85xx: add proper OF bus ids for the TQM85xx

["Grant Likely" <grant.likely@secretlab.ca>]

On Fri, Jul 25, 2008 at 3:44 AM, Wolfgang Grandegger <wg@grandegger.com> wrote:
> Since recent modifications to the MPC I2C code, the MPC I2C buses are not
> found any more. This patch fixes the problem by adding proper OF
> bus ids.
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> ---
> arch/powerpc/platforms/85xx/tqm85xx.c |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6-galak/arch/powerpc/platforms/85xx/tqm85xx.c
> ===================================================================
> --- linux-2.6-galak.orig/arch/powerpc/platforms/85xx/tqm85xx.c
> +++ linux-2.6-galak/arch/powerpc/platforms/85xx/tqm85xx.c
> @@ -156,15 +156,15 @@ static void tqm85xx_show_cpuinfo(struct }
>
> static struct of_device_id __initdata of_bus_ids[] = {
> +       { .type = "soc", },
> +       { .compatible = "soc", },
>        { .compatible = "simple-bus", },

Ugh, i assume this is to support older .dts files that don't have
simple-bus in their compatible property?  Please put them at the end
of the list and put a comment ahead of them stating that they are
legacy support.  You should also state in the comment which boards or
dts files these entries provide support for.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.