From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.245]) by ozlabs.org (Postfix) with ESMTP id 83C17DDFFA for ; Wed, 6 Aug 2008 07:05:08 +1000 (EST) Received: by an-out-0708.google.com with SMTP id c34so494899anc.78 for ; Tue, 05 Aug 2008 14:05:07 -0700 (PDT) Message-ID: Date: Tue, 5 Aug 2008 15:05:06 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "John Rigby" Subject: Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree. In-Reply-To: <1217967220-30557-2-git-send-email-jrigby@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1217967220-30557-1-git-send-email-jrigby@freescale.com> <1217967220-30557-2-git-send-email-jrigby@freescale.com> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 5, 2008 at 2:13 PM, John Rigby wrote: > So get_immrbase can function without a device_type = "soc" > property in the soc node. > > The "soc" node should really be named "immr" > because it does not include the entire soc, however > u-boot currently looks up this node by name for > a clock fixup so leave it "soc" for now. We will change > it later after 5121 u-boot uses the immr alias instead > of the node name. Is it not sufficient to search the tree for a node with the -immr compatible value? I don't think this is the intended use case of aliases. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.