From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Scott Wood" <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org,
John Rigby <jrigby@freescale.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists.
Date: Tue, 5 Aug 2008 15:08:11 -0600 [thread overview]
Message-ID: <fa686aa40808051408j34dedabg760c68480ead0f24@mail.gmail.com> (raw)
In-Reply-To: <4898BCD3.5050703@freescale.com>
On Tue, Aug 5, 2008 at 2:49 PM, Scott Wood <scottwood@freescale.com> wrote:
> Arnd Bergmann wrote:
>>
>> On Tuesday 05 August 2008, John Rigby wrote:
>>>
>>> This will allow the eventual removal of device_type = "soc"
>>> properties in soc nodes.
>>
>> Stupid question, but why not remove immrbase instead?
>>
>> It seems that all users can be converted to use a reg
>> property of some actual device instead of making assumptions
>> about the register layout of the whole SOC.
>
> That wouldn't eliminate the need for the alias, though -- u-boot needs to
> find the node to fill in properties.
(already made this comment on one of the later patches, but it is more
relevant here...)
I don't think that using aliases is the best solution. I'd rather see
U-Boot search for the appropriate compatible value for the IMMR node.
g.
>
> -Scott
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-08-05 21:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:13 [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 3/4] powerpc: 83xx: Add immr aliases to 83xx device trees John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 4/4] powerpc: 8[56]xx: Add immr aliases to 8[56]xx " John Rigby
2008-08-05 21:05 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree Grant Likely
2008-08-05 21:05 ` Grant Likely
2008-08-05 21:17 ` John Rigby
2008-08-05 21:20 ` Scott Wood
2008-08-05 21:38 ` John Rigby
2008-08-05 21:08 ` Scott Wood
2008-08-05 21:12 ` Grant Likely
2008-08-05 21:19 ` Scott Wood
2008-08-05 23:46 ` Anton Vorontsov
2008-08-05 20:43 ` [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists Arnd Bergmann
2008-08-05 20:49 ` Scott Wood
2008-08-05 20:50 ` Kumar Gala
2008-08-05 21:08 ` Grant Likely [this message]
2008-08-06 3:41 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40808051408j34dedabg760c68480ead0f24@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@ozlabs.org \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).