From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Scott Wood" <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, John Rigby <jrigby@freescale.com>
Subject: Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.
Date: Tue, 5 Aug 2008 15:12:59 -0600 [thread overview]
Message-ID: <fa686aa40808051412od699a57x59079bc59fb7150@mail.gmail.com> (raw)
In-Reply-To: <4898C15E.3000900@freescale.com>
On Tue, Aug 5, 2008 at 3:08 PM, Scott Wood <scottwood@freescale.com> wrote:
> Grant Likely wrote:
>>
>> Is it not sufficient to search the tree for a node with the
>> <chip>-immr compatible value? I don't think this is the intended use
>> case of aliases.
>
> That get's really annoying in code that is meant to deal with multiple
> chips. I don't think finding the network or serial node that corresponds to
> u-boot's enumeration is what it's meant for, either, but pretty much any
> alternative you can come up with has someone saying that it's not what
> *that* was meant for, either.
But finding nodes that meet a criteria *is* what compatible is for and
there is precedence for it. All u-boot platforms are finding the node
by path right now, and so all of them need to be changed. Changing
them to find by compatible that is set per-board or per-SoC makes
complete sense to me.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-08-05 21:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:13 [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 3/4] powerpc: 83xx: Add immr aliases to 83xx device trees John Rigby
2008-08-05 20:13 ` [PATCH add immr alias 4/4] powerpc: 8[56]xx: Add immr aliases to 8[56]xx " John Rigby
2008-08-05 21:05 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree Grant Likely
2008-08-05 21:05 ` Grant Likely
2008-08-05 21:17 ` John Rigby
2008-08-05 21:20 ` Scott Wood
2008-08-05 21:38 ` John Rigby
2008-08-05 21:08 ` Scott Wood
2008-08-05 21:12 ` Grant Likely [this message]
2008-08-05 21:19 ` Scott Wood
2008-08-05 23:46 ` Anton Vorontsov
2008-08-05 20:43 ` [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists Arnd Bergmann
2008-08-05 20:49 ` Scott Wood
2008-08-05 20:50 ` Kumar Gala
2008-08-05 21:08 ` Grant Likely
2008-08-06 3:41 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40808051412od699a57x59079bc59fb7150@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).