From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Thu, 7 Aug 2008 08:33:26 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Jean Delvare" Subject: Re: [PATCH] i2c-mpc: suppress I2C device probing In-Reply-To: <20080807130717.56694249@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <487F20EC.9040503@grandegger.com> <20080807102126.5980c761@hyperion.delvare> <489ACC69.5070701@grandegger.com> <489AD363.6070608@scram.de> <20080807130717.56694249@hyperion.delvare> Cc: Linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 7, 2008 at 5:07 AM, Jean Delvare wrote: > On Thu, 07 Aug 2008 12:50:11 +0200, Jochen Friedrich wrote: >> Hi Wolfgang, >> >> > $ grep I2C_CLASS_HWMON * >> > i2c-cpm.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, >> > i2c-mpc.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, >> > i2c-ibm_iic.c: adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD; >> > i2c-pasemi.c: smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD; >> > i2c-mv64xxx.c: drv_data->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD; >> > >> > It would be consequent to remove them as well. >> >> ACK for the i2c-cpm part. > > No objection on my side. It's really up to each platform to choose the > way they want to handle i2c device creation, and stick to it. > > As I understand it, the removal of the adapter class needs to be > synchronized with platform code changes. Thus it might make sense to > push these through their respective arch trees, rather than the i2c > tree. All right, I'm happy to pick these patches up if nobody objects. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.