From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Tim Yamin" <plasm@roo.me.uk>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH]: [MPC5200] Add ATA DMA support
Date: Wed, 13 Aug 2008 00:02:01 -0600 [thread overview]
Message-ID: <fa686aa40808122302g197a8e90idc721796aa35ff05@mail.gmail.com> (raw)
In-Reply-To: <792f5f410808122257t3711eb2lfc1e02bacade16a3@mail.gmail.com>
On Tue, Aug 12, 2008 at 11:57 PM, Tim Yamin <plasm@roo.me.uk> wrote:
> On Tue, Aug 12, 2008 at 6:30 PM, Daniel Schnell
> <daniel.schnell@marel.com> wrote:
>> Hi Tim,
>>
>> Continuing the discussion on the mailing list ...
>>
>> Looking at the original patch I don't undestand why you had to duplicate
>> the bestcomm data structures and functions. The only apparent difference
>> is that you have a minimal data length of 2 bytes instead of 1. Does
>> this make any difference as the bd_size will be filled with the correct
>> length value anyway ?
>
> The "new" version of the patch does this the correct way. I just
> haven't back ported this to the 2.6.24 version that I sent you.
While on this topic; have you had a chance to address the comments you
received on v2 of your patch? I'm keen to get your change merged in,
but there are a few more things that need to be sorted out.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-08-13 6:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DD39B5C3F4963040ADC9768BE7E430CB03202F4F@is-hdq-exchange.marel.net>
[not found] ` <DD39B5C3F4963040ADC9768BE7E430CB03203863@is-hdq-exchange.marel.net>
[not found] ` <792f5f410808111319m20d6e09bi8e9782da1fdd4aab@mail.gmail.com>
[not found] ` <DD39B5C3F4963040ADC9768BE7E430CB0320387D@is-hdq-exchange.marel.net>
[not found] ` <792f5f410808111431g8fafba1n3b10468da0d165bf@mail.gmail.com>
[not found] ` <DD39B5C3F4963040ADC9768BE7E430CB03203A7B@is-hdq-exchange.marel.net>
[not found] ` <792f5f410808120643md72e679o39692c4bfa3f285e@mail.gmail.com>
[not found] ` <DD39B5C3F4963040ADC9768BE7E430CB03203A94@is-hdq-exchange.marel.net>
[not found] ` <792f5f410808120730j7b4be4f2n7a40de880178ccca@mail.gmail.com>
[not found] ` <DD39B5C3F4963040ADC9768BE7E430CB03203ADC@is-hdq-exchange.marel.net>
[not found] ` <792f5f410808120830v311e0446kc8fddfb97d0b9ea6@mail.gmail.com>
2008-08-12 17:30 ` [PATCH]: [MPC5200] Add ATA DMA support Daniel Schnell
2008-08-13 5:57 ` Tim Yamin
2008-08-13 6:02 ` Grant Likely [this message]
2008-08-13 6:06 ` Tim Yamin
2008-08-13 6:11 ` Grant Likely
2008-08-13 9:07 ` Tim Yamin
2008-09-15 5:54 ` Grant Likely
2008-10-29 15:34 ` Matt Sealey
2008-11-11 14:04 ` Lehmann, Hans (Ritter Elektronik)
2008-11-11 14:35 ` Matt Sealey
2008-11-11 15:04 ` AW: " Lehmann, Hans (Ritter Elektronik)
2008-11-11 16:16 ` Matt Sealey
[not found] <AclPDG6qSkF9cHawTOKR6zBfDIjvgg==>
2008-11-25 14:45 ` Lehmann, Hans (Ritter Elektronik)
2008-11-25 15:19 ` Matt Sealey
2008-12-20 7:15 ` Grant Likely
2008-12-20 7:18 ` Grant Likely
2009-01-05 9:25 ` AW: " Lehmann, Hans (Ritter Elektronik)
2009-01-05 15:31 ` Grant Likely
2009-07-09 14:24 ` Roman Fietze
2008-09-05 18:29 WITTROCK
-- strict thread matches above, loose matches on Subject: below --
2008-06-17 8:28 Tim Yamin
2008-08-06 11:58 ` Daniel Schnell
2008-08-06 12:18 ` Tim Yamin
2008-08-06 13:26 ` Daniel Schnell
2008-08-06 14:31 ` Daniel Schnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40808122302g197a8e90idc721796aa35ff05@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=plasm@roo.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).