From: "Grant Likely" <grant.likely@secretlab.ca>
To: temerkhanov@cifronik.ru
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [RFC] Fix level IRQ handling on Xilinx INTC with ARCH=powerpc
Date: Mon, 25 Aug 2008 08:26:54 -0600 [thread overview]
Message-ID: <fa686aa40808250726q69a40f9crd814ce52685c071b@mail.gmail.com> (raw)
In-Reply-To: <200808251656.00247.temerkhanov@yandex.ru>
On Mon, Aug 25, 2008 at 6:55 AM, Sergey Temerkhanov
<temerkhanov@yandex.ru> wrote:
> This fixes the missing acknowledge at the end of handle_level_irq().
>
> It adds a field flags to struct irq_chip. If IRQ_CHIP_UNMASK_ACK is set in
> this field, acknowledge is performed before unmasking.
Can this fix be handled in the XINTC controller driver itself? This
patch unconditionally adds what is essentially a device specific fixup
to *every* Linux platform. I cannot see that flying very far.
g.
next prev parent reply other threads:[~2008-08-25 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 12:55 [PATCH] [RFC] Fix level IRQ handling on Xilinx INTC with ARCH=powerpc Sergey Temerkhanov
2008-08-25 14:26 ` Grant Likely [this message]
2008-08-25 15:02 ` Sergey Temerkhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40808250726q69a40f9crd814ce52685c071b@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=temerkhanov@cifronik.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox