From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.225]) by ozlabs.org (Postfix) with ESMTP id 9099CDE063 for ; Fri, 17 Oct 2008 10:02:56 +1100 (EST) Received: by rv-out-0506.google.com with SMTP id f6so208616rvb.9 for ; Thu, 16 Oct 2008 16:02:55 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2008 17:02:54 -0600 From: "Grant Likely" To: "David Miller" Subject: Re: [PATCH 1/7] powerpc and sparc: introduce dev_archdata node accessors In-Reply-To: <20081016.153641.32547403.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20081016171222.GA24812@oksana.dev.rtsoft.ru> <20081016171251.GA5515@oksana.dev.rtsoft.ru> <20081016.153641.32547403.davem@davemloft.net> Cc: dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, i2c@lm-sensors.org, khali@linux-fr.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Oct 16, 2008 at 4:36 PM, David Miller wrote: > From: Anton Vorontsov > Date: Thu, 16 Oct 2008 21:12:51 +0400 > >> The name of the device_node field differ across the platforms, so we >> have to implement inlined accessors. This is needed to avoid ugly >> #ifdef in the generic code. >> >> Signed-off-by: Anton Vorontsov > > I'm happy to just change this member name on sparc to match > powerpc's choice. > > That being said, this abstraction still has value and I'd > like to let you merge this now and make forward progress > so: > > Acked-by: David S. Miller I agree; Acked-by: Grant Likely -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.