From: "Grant Likely" <grant.likely@secretlab.ca>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>,
Wolfgang Ocker <weo@reccoware.de>
Subject: Re: [PATCH v3] powerpc: Specify GPIO number base for controller in DT
Date: Fri, 24 Oct 2008 11:12:26 -0600 [thread overview]
Message-ID: <fa686aa40810241012o57e85215i9778efc342250137@mail.gmail.com> (raw)
In-Reply-To: <20081024165428.GC14350@oksana.dev.rtsoft.ru>
On Fri, Oct 24, 2008 at 10:54 AM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> On Thu, Oct 23, 2008 at 08:13:00PM +0200, Stefan Roese wrote:
>> On Thursday 23 October 2008, Wolfgang Ocker wrote:
>> > The GPIOLIB allows the specification of a base gpio number for a
>> > controller. That is not possible using OF. Instead, free gpio numbers
>> > are assigned.
>> >
>> > In order to allow static, predefined gpio numbers, a base property in
>> > the gpio controller node specifies the first gpio number.
>> >
>> > v2, v3: added/improved description of base property in doc
>>
>> These version descriptions are better placed below the "---" line. And you
>> should remove the "Re: " from the subject line. Other than this:
>>
>> Acked-by: Stefan Roese <sr@denx.de>
>
> Please-defer-this-patch-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> Wolfgang, Stefan, see this comment:
>
> http://ozlabs.org/pipermail/linuxppc-dev/2008-October/064505.html
>
> ..just tell me what are you trying to solve.
Yeah, I don't like this patch either. GPIO numbering is a Linux
internal detail and has no bearing on the hardware description. If
you need to know what a particular gpio number is then it should be
resolved by finding the device tree node; not by trying to fix a GPIO
controller to a particular number.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-10-24 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 12:27 [PATCH] powerpc: Specify GPIO number base for controller in DT Wolfgang Ocker
2008-10-23 14:18 ` Kumar Gala
2008-10-23 14:30 ` [PATCH v2] " Wolfgang Ocker
2008-10-23 14:40 ` Kumar Gala
2008-10-23 14:49 ` [PATCH v3] " Wolfgang Ocker
2008-10-23 18:13 ` Stefan Roese
2008-10-24 16:54 ` Anton Vorontsov
2008-10-24 17:12 ` Grant Likely [this message]
2008-10-24 18:00 ` Wolfgang Ocker
2008-10-23 21:35 ` [PATCH] " Matt Sealey
2008-10-24 16:10 ` Wolfgang Ocker
2008-10-24 16:45 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40810241012o57e85215i9778efc342250137@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
--cc=weo@reccoware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).