From: "Grant Likely" <grant.likely@secretlab.ca>
To: avorontsov@ru.mvista.com
Cc: Kiran Sutariya <kirans@xilinx.com>,
linuxppc-dev@ozlabs.org, John Linn <john.linn@xilinx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [powerpc] GPIO: Adding new Xilinx driver
Date: Fri, 24 Oct 2008 15:53:49 -0600 [thread overview]
Message-ID: <fa686aa40810241453o876ae14tce3df7723b0f621b@mail.gmail.com> (raw)
In-Reply-To: <20081024214159.GA15204@oksana.dev.rtsoft.ru>
On Fri, Oct 24, 2008 at 3:41 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> On Fri, Oct 24, 2008 at 12:59:00PM -0700, John Linn wrote:
>> This driver supports the Xilinx XPS GPIO IP core which has the typical
>> GPIO features.
>>
>> Signed-off-by: Kiran Sutariya <kirans@xilinx.com>
>> Signed-off-by: John Linn <john.linn@xilinx.com>
>
> Looks good. Just few comments below.
>
<snip>
>
> If nothing has changed, we should place the arch-specific GPIO
> drivers into the arch/. So, Kconfig entry should go into the
> arch/powerpc/platforms/Kconfig.
>
> and the driver itself into arch/powerpc/sysdev/.
This isn't just a powerpc driver. It is also used by microblaze so
I'd like to keep it in the common directory (Microblaze is in the
process of being reviewed for merging).
Thanks for the comments.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-10-24 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 19:59 [PATCH] [powerpc] GPIO: Adding new Xilinx driver John Linn
2008-10-24 20:03 ` Grant Likely
2008-10-24 21:41 ` Anton Vorontsov
2008-10-24 21:53 ` Grant Likely [this message]
2008-10-25 6:07 ` Grant Likely
2008-10-25 10:10 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40810241453o876ae14tce3df7723b0f621b@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=john.linn@xilinx.com \
--cc=kirans@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).