From: "Grant Likely" <grant.likely@secretlab.ca>
To: avorontsov@ru.mvista.com
Cc: Kiran Sutariya <kirans@xilinx.com>,
linuxppc-dev@ozlabs.org, John Linn <john.linn@xilinx.com>
Subject: Re: [PATCH] [powerpc] GPIO: Adding new Xilinx driver
Date: Sat, 25 Oct 2008 00:07:06 -0600 [thread overview]
Message-ID: <fa686aa40810242307o31bdd128x4ea38627f504aa6e@mail.gmail.com> (raw)
In-Reply-To: <20081024214159.GA15204@oksana.dev.rtsoft.ru>
On Fri, Oct 24, 2008 at 3:41 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> On Fri, Oct 24, 2008 at 12:59:00PM -0700, John Linn wrote:
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 7f2ee27..f6b0da8 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -65,6 +65,14 @@ config GPIO_SYSFS
>>
>> # put expanders in the right section, in alphabetical order
>>
>> +comment "Memory mapped GPIO expanders:"
>> +
>> +config GPIO_XILINX
>> + bool "Xilinx GPIO support"
>> + depends on OF
>
> I persume that the driver wasn't build-tested on SPARC, so I'd recommend
> to change the depends to PPC_OF. Plus, the driver should also select
> GENERIC_GPIO and ARCH_REQUIRE_GPIOLIB. (Later we'll switch to
> ARCH_WANT_OPTIONAL_GPIOLIB for whole PPC.)
ARCH_WANT_OPTIONAL_GPIOLIB seems to already be set for all of powerpc
(arch/powerpc/Kconfig, line 113).
But, since this is a cross-arch driver living in drivers/gpio the
dependencies work the other way around. This driver cannot be
selected unless GPIOLIB is turned on.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-10-25 6:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 19:59 [PATCH] [powerpc] GPIO: Adding new Xilinx driver John Linn
2008-10-24 20:03 ` Grant Likely
2008-10-24 21:41 ` Anton Vorontsov
2008-10-24 21:53 ` Grant Likely
2008-10-25 6:07 ` Grant Likely [this message]
2008-10-25 10:10 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40810242307o31bdd128x4ea38627f504aa6e@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=john.linn@xilinx.com \
--cc=kirans@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).