From: "Grant Likely" <grant.likely@secretlab.ca>
To: "John Linn" <john.linn@xilinx.com>
Cc: Kiran Sutariya <kirans@xilinx.com>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH][V2] [powerpc] GPIO: Adding new Xilinx driver
Date: Mon, 27 Oct 2008 10:53:04 -0600 [thread overview]
Message-ID: <fa686aa40810270953j38be56dbq22ccc3a10752a74f@mail.gmail.com> (raw)
In-Reply-To: <20081027163908.0E79F5C8057@mail75-dub.bigfish.com>
On Mon, Oct 27, 2008 at 10:39 AM, John Linn <john.linn@xilinx.com> wrote:
> This driver supports the Xilinx XPS GPIO IP core which has the typical
> GPIO features.
>
> Signed-off-by: Kiran Sutariya <kirans@xilinx.com>
> Signed-off-by: John Linn <john.linn@xilinx.com>
> ---
> V2 - Updated based on Anton's comments
>
> drivers/gpio/Kconfig | 15 ++--
> drivers/gpio/Makefile | 1 +
> drivers/gpio/xilinx_gpio.c | 235 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 244 insertions(+), 7 deletions(-)
> create mode 100644 drivers/gpio/xilinx_gpio.c
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 7f2ee27..12a8006 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -127,13 +135,6 @@ config GPIO_PCF857X
> This driver provides an in-kernel interface to those GPIOs using
> platform-neutral GPIO calls.
>
> -config GPIO_TWL4030
> - tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> - depends on TWL4030_CORE
> - help
> - Say yes here to access the GPIO signals of various multi-function
> - power management chips from Texas Instruments.
> -
Looks like you've got some colateral damage in here. Otherwise looks
right to me.
When you repost, please add my Signed-off-by line between yours and
Kiran's since I did a bunch of hacking on this driver too. Also, make
use you post it to the LKML.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2008-10-27 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 16:39 [PATCH][V2] [powerpc] GPIO: Adding new Xilinx driver John Linn
2008-10-27 16:53 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40810270953j38be56dbq22ccc3a10752a74f@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=john.linn@xilinx.com \
--cc=kirans@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).