From: "Grant Likely" <grant.likely@secretlab.ca>
To: "René Bürgel" <r.buergel@unicontrol.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc52xx_uart: report serial errors to users
Date: Thu, 30 Oct 2008 09:19:03 -0600 [thread overview]
Message-ID: <fa686aa40810300819w265c375euff3f46d7bb0a9176@mail.gmail.com> (raw)
In-Reply-To: <490950AF.1000303@unicontrol.de>
On Thu, Oct 30, 2008 at 12:14 AM, Ren=E9 B=FCrgel <r.buergel@unicontrol.de>=
wrote:
> Hi! This patch adds the capability to the mpc52xx-uart to report framing
> errors, parity errors, breaks and overruns to userspace. These values may=
be
> requested in userspace by using the ioctl TIOCGICOUNT.
>
> Signed-off-by: Ren=E9 B=FCrgel <r.buergel@unicontrol.de>
Looks mostly good. A few comments below. Make sure you CC: me when
you send the next version (which goes for all 5xxx patches).
g.
>
> Kind regards, Ren=E9 B=FCrgel
>
> --
> Ren=E9 B=FCrgel
> Software Engineer
> Unicontrol Systemtechnik GmbH
> OT Dittersbach
> Sachsenburger Weg 34
> 09669 Frankenberg
>
> Tel.: 03 72 06/ 88 73 - 19
> Fax: 03 72 06/ 88 73 - 60
> E-Mail: r.buergel@unicontrol.de
> Internet: www.unicontrol.de
>
>
>
> --- drivers/serial/mpc52xx_uart.c 2008-08-07 15:55:43.000000000 +02=
00
> +++ drivers/serial/mpc52xx_uart_orig.c 2008-09-11 13:19:12.000000000 +02=
00
Patch is one level too shallow; for regular tools to work without
manual intervention you should be generating the patch from the
directory above the kernel source.
> @@ -752,10 +752,17 @@
> if (status & MPC52xx_PSC_SR_RB) {
> flag =3D TTY_BREAK;
> uart_handle_break(port);
> + port->icount.brk++;
> } else if (status & MPC52xx_PSC_SR_PE)
> + {
Please use '} else if () {' form
> flag =3D TTY_PARITY;
> + port->icount.parity++;
> + }
> else if (status & MPC52xx_PSC_SR_FE)
> + {
ditto
> flag =3D TTY_FRAME;
> + port->icount.frame++;
> + }
>
> /* Clear error condition */
> out_8(&PSC(port)->command, MPC52xx_PSC_RST_ERR_STA=
T);
> @@ -769,6 +776,7 @@
> * affect the current character
> */
> tty_insert_flip_char(tty, 0, TTY_OVERRUN);
> + port->icount.overrun++;
> }
> }
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-10-30 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 6:14 [PATCH] mpc52xx_uart: report serial errors to users René Bürgel
2008-10-30 15:19 ` Grant Likely [this message]
2008-11-03 9:35 ` [PATCH] mpc52xx_uart: report serial errors to users v2 René Bürgel
-- strict thread matches above, loose matches on Subject: below --
2008-10-29 17:22 [PATCH] mpc52xx_uart: report serial errors to users René Bürgel
2008-10-29 18:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40810300819w265c375euff3f46d7bb0a9176@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=r.buergel@unicontrol.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).