Re: [PATCH 5/5] ide: Force VIA IDE legacy interrupts for AmigaOne boards

["Grant Likely" <grant.likely@secretlab.ca>]

On Wed, Jan 7, 2009 at 7:12 AM, Gerhard Pircher <gerhard_pircher@gmx.net> wrote:
> The AmigaOne uses the onboard VIA IDE controller in legacy mode (like the
> Pegasos).
>
> Signed-off-by: Gerhard Pircher <gerhard_pircher@gmx.net>
> ---
>  drivers/ide/via82cxxx.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

This patch needs to also be posted on the linux-ide mailing list.

> diff --git a/drivers/ide/via82cxxx.c b/drivers/ide/via82cxxx.c
> index 2a812d3..086f476 100644
> --- a/drivers/ide/via82cxxx.c
> +++ b/drivers/ide/via82cxxx.c
> @@ -450,6 +450,11 @@ static int __devinit via_init_one(struct pci_dev *dev, const struct pci_device_i
>                d.host_flags |= IDE_HFLAG_FORCE_LEGACY_IRQS;
>  #endif
>
> +#ifdef CONFIG_AMIGAONE
> +       if (machine_is(amigaone))
> +               d.host_flags |= IDE_HFLAG_FORCE_LEGACY_IRQS;
> +#endif
> +

I know you're just following the example of the PEGASOS workaround
immediately above; but the #defines are really ugly.  I wonder if
there is there a cleaner way to manipulate the flags.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.