Re: [PATCH 1/5] powerpc: Add platform support for AmigaOne

["Grant Likely" <grant.likely@secretlab.ca>]

On Wed, Jan 7, 2009 at 6:54 AM, Gerhard Pircher <gerhard_pircher@gmx.net> wrote:
> +
> +void amigaone_show_cpuinfo(struct seq_file *m)
> +{
> +       struct device_node *root;
> +       const char *model = "";
> +
> +       root = of_find_node_by_path("/");
> +       if (root)
> +               model = of_get_property(root, "model", NULL);
> +       seq_printf(m, "machine\t\t: %s\n", model);
> +
> +       of_node_put(root);
> +       return;
> +}

show_cpuinfo() common code already prints the model.  You can drop this hook.

> +void __init amigaone_setup_arch(void)
> +{
> +       struct device_node *np;
> +
> +       /* Initialization until calibrate_delay() runs. */
> +       loops_per_jiffy = 50000000/HZ;

If it doesn't noticeably slow down the boot then I would remove this line.

Otherwise looks okay to me.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.