From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.28]) by ozlabs.org (Postfix) with ESMTP id 6FC14DE0FF for ; Wed, 28 Jan 2009 04:54:57 +1100 (EST) Received: by yw-out-2324.google.com with SMTP id 5so2456240ywh.39 for ; Tue, 27 Jan 2009 09:54:55 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20090121205506.31232.27908.stgit@localhost.localdomain> <20090121205540.31232.77034.stgit@localhost.localdomain> Date: Tue, 27 Jan 2009 10:54:55 -0700 Message-ID: Subject: Re: [PATCH 7/8] powerpc/5200: Refactor mpc5200 interrupt controller driver From: Grant Likely To: Matt Sealey Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jan 27, 2009 at 10:52 AM, Matt Sealey wrote: > On Wed, Jan 21, 2009 at 2:55 PM, Grant Likely wrote: >> From: Grant Likely >> >> Rework the mpc5200-pic driver to simplify it and fix up the setting >> of desc->status when set_type is called for internal IRQs (so they >> are reported as level, not edge). The simplification is due to >> splitting off the handling of external IRQs into a separate block >> so they don't need to be handled as exceptions in the normal >> CRIT, MAIN and PERP paths. > > Can I assume this has absolutely no functional impact compared to the > old one? It doesn't change any behaviour, just implements exactly the > same in a much nicer way? Plus small bug fixes. It should have no functional impact on stuff that already works. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.