From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gx0-f20.google.com (mail-gx0-f20.google.com [209.85.217.20]) by ozlabs.org (Postfix) with ESMTP id E7A4ADE0E9 for ; Wed, 28 Jan 2009 05:06:28 +1100 (EST) MIME-Version: 1.0 In-Reply-To: References: <20090121205506.31232.27908.stgit@localhost.localdomain> Date: Tue, 27 Jan 2009 11:06:26 -0700 Message-ID: Subject: Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation From: Grant Likely To: Matt Sealey Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, devtree-discuss@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jan 27, 2009 at 11:00 AM, Matt Sealey wrote: > On Wed, Jan 21, 2009 at 2:55 PM, Grant Likely wrote: >> From: Grant Likely >> >> This patch updates the mpc5200 binding documentation to match >> actual usage conventions, to remove incorrect information, and >> to remove topics which are more thoroughly described elsewhere. >> >> Signed-off-by: Grant Likely >> CC: devtree-discuss@ozlabs.org >> CC: Wolfram Sang >> --- >> +It is *strongly* recommended that 5200B device trees follow this convention >> +(instead of only listing the base mpc5200 item). >> + >> +ie. ethernet on mpc5200: compatible = "fsl,mpc5200-ethernet"; >> + ethernet on mpc5200b: compatible = "fsl,mpc5200b-ethernet", >> + "fsl,mpc5200-ethernet"; > > snip > >> +ethernet@ fsl,mpc5200-fec MPC5200 ethernet device > > snip > >> +fsl,mpc5200-fec nodes >> +--------------------- >> +The FEC node can specify one of the following properties to configure >> +the MII link: > > > Is it fec or ethernet? Obviously the first one is an example only but > it should least reflect real life.. Good catch. It should be -fec. Fixed. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.