From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032)
Date: Sun, 1 Mar 2009 07:48:44 -0700 [thread overview]
Message-ID: <fa686aa40903010648q238380acy34b58e04226d8014@mail.gmail.com> (raw)
In-Reply-To: <20090301101815.GC23093@pengutronix.de>
On Sun, Mar 1, 2009 at 3:18 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> Hi Grant,
>
> thanks for the review!
>
> On Thu, Feb 26, 2009 at 10:31:24PM -0700, Grant Likely wrote:
>> Thanks for the patch Wolfram. =A0Comments below.
>>
>> On Wed, Feb 25, 2009 at 8:32 AM, Wolfram Sang <w.sang@pengutronix.de> wr=
ote:
>> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
>> > ---
>> > =A0arch/powerpc/boot/dts/pcm032.dts =A0 =A0 =A0 =A0 =A0 =A0 | =A0391 +=
++++++
>> > =A0arch/powerpc/configs/52xx/pcm032_defconfig =A0 | 1394 +++++++++++++=
+++++++++++++
>>
>> Do you really need a separate defconfig for this board? =A0Can it be
>> merged with an existing defconfig?
>
> Will have a look if I can make a pcm03x_defconfig out of pcm030_defconfig=
.
Cool, thanks.
>> motionpro.dts is a good example of what it should look like.
>
> Ah, thanks for the pointer. Will have a look there. Guess I'll need to up=
date
> pcm030.dts later, too (from which I copied this one). Will rewrite the
> localbus-node addressing the comments you gave.
pcm030.dts in mainline doesn't have a localbus node.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-03-01 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 15:32 [PATCH] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032) Wolfram Sang
2009-02-25 15:40 ` Wolfram Sang
2009-02-27 5:31 ` Grant Likely
2009-03-01 10:18 ` Wolfram Sang
2009-03-01 14:48 ` Grant Likely [this message]
2009-03-01 15:54 ` Jon Smirl
2009-03-01 22:47 ` Grant Likely
2009-03-02 0:37 ` Jon Smirl
2009-03-02 0:46 ` Jon Smirl
2009-03-02 1:07 ` Grant Likely
2009-03-02 2:15 ` Jon Smirl
2009-03-02 2:19 ` Jon Smirl
2009-03-02 4:33 ` Grant Likely
2009-03-03 8:12 ` Robert Schwebel
2009-03-07 2:01 ` Jon Smirl
2009-03-10 16:03 ` [PATCH v2] " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40903010648q238380acy34b58e04226d8014@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).