From: Grant Likely <grant.likely@secretlab.ca>
To: Jens Axboe <axboe@kernel.dk>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de,
linux-kernel@vger.kernel.org, John.Linn@xilinx.com
Subject: Re: [PATCH] Fix Xilinx SystemACE driver to handle empty CF slot
Date: Fri, 6 Mar 2009 09:05:33 -0700 [thread overview]
Message-ID: <fa686aa40903060805i489d8676waad08e8263c02fe@mail.gmail.com> (raw)
In-Reply-To: <20090228204622.29719.55082.stgit@localhost.localdomain>
Oops, sorry Jens. I forgot to CC: you on this patch.
g.
On Sat, Feb 28, 2009 at 1:46 PM, Grant Likely <grant.likely@secretlab.ca> w=
rote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> The SystemACE driver does not handle an empty CF slot gracefully. =A0An
> empty CF slot ends up hanging the system. =A0This patch adds a check for
> the CF state and stops trying to process requests if the slot is empty.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> =A0drivers/block/xsysace.c | =A0 22 ++++++++++++++++++++++
> =A01 files changed, 22 insertions(+), 0 deletions(-)
>
>
> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
> index 381d686..ec5b8ca 100644
> --- a/drivers/block/xsysace.c
> +++ b/drivers/block/xsysace.c
> @@ -489,6 +489,28 @@ static void ace_fsm_dostate(struct ace_device *ace)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ace->fsm_state, ace->id_req_count);
> =A0#endif
>
> + =A0 =A0 =A0 /* Verify that there is actually a CF in the slot. =A0If no=
t, then
> + =A0 =A0 =A0 =A0* bail out back to the idle state and wake up all the wa=
iters */
> + =A0 =A0 =A0 status =3D ace_in32(ace, ACE_STATUS);
> + =A0 =A0 =A0 if ((status & ACE_STATUS_CFDETECT) =3D=3D 0) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ace->fsm_state =3D ACE_FSM_STATE_IDLE;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ace->media_change =3D 1;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 set_capacity(ace->gd, 0);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 dev_info(ace->dev, "No CF in slot\n");
> +
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Drop all pending requests */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 while ((req =3D elv_next_request(ace->queue=
)) !=3D NULL)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 end_request(req, 0);
> +
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Drop back to IDLE state and notify waite=
rs */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ace->fsm_state =3D ACE_FSM_STATE_IDLE;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ace->id_result =3D -EIO;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 while (ace->id_req_count) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 complete(&ace->id_completio=
n);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ace->id_req_count--;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
> + =A0 =A0 =A0 }
> +
> =A0 =A0 =A0 =A0switch (ace->fsm_state) {
> =A0 =A0 =A0 =A0case ACE_FSM_STATE_IDLE:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* See if there is anything to do */
>
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-03-06 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 20:46 [PATCH] Fix Xilinx SystemACE driver to handle empty CF slot Grant Likely
2009-03-06 16:05 ` Grant Likely [this message]
2009-03-06 20:46 ` Jens Axboe
2009-03-06 20:56 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40903060805i489d8676waad08e8263c02fe@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=John.Linn@xilinx.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).