* [PATCH] powerpc: Remove extra semicolon in fsl_soc.c
@ 2009-03-11 15:50 Johns Daniel
2009-03-11 16:03 ` Grant Likely
0 siblings, 1 reply; 4+ messages in thread
From: Johns Daniel @ 2009-03-11 15:50 UTC (permalink / raw)
To: afleming, linuxppc-dev, stable
A semicolon at the end of the macro means that the for loop has an
empty body, and so TSEC/MDIO will not work with older device trees.
This fix only applies to 2.6.28; apparently, this code is gone for
2.6.29, according to Grant Likely!
Signed-off-by: Johns Daniel <johns.daniel@gmail.com>
---
--- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig 2009-02-20
16:41:27.000000000 -0600
+++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c 2009-03-10
15:56:47.000000000 -0500
@@ -257,7 +257,7 @@
gfar_mdio_of_init_one(np);
/* try the deprecated version */
- for_each_compatible_node(np, "mdio", "gianfar");
+ for_each_compatible_node(np, "mdio", "gianfar")
gfar_mdio_of_init_one(np);
return 0;
---
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c 2009-03-11 15:50 [PATCH] powerpc: Remove extra semicolon in fsl_soc.c Johns Daniel @ 2009-03-11 16:03 ` Grant Likely 2009-03-11 16:05 ` [stable] " Greg KH 2009-03-13 6:03 ` Greg KH 0 siblings, 2 replies; 4+ messages in thread From: Grant Likely @ 2009-03-11 16:03 UTC (permalink / raw) To: Johns Daniel; +Cc: linuxppc-dev, Greg KH, afleming, stable On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrot= e: > A semicolon at the end of the macro means that the for loop has an > empty body, and so TSEC/MDIO will not work with older device trees. > > This fix only applies to 2.6.28; apparently, this code is gone for > 2.6.29, according to Grant Likely! > > Signed-off-by: Johns Daniel <johns.daniel@gmail.com> Acked-by: Grant Likely <grant.likely@secretlab.ca> Greg: Andy Flemming should probably confirm this, but I think this one should be backported to the stable series. g. > --- > --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig =A0 2009-02-20 > 16:41:27.000000000 -0600 > +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c =A0 =A0 =A0 =A02009-03-1= 0 > 15:56:47.000000000 -0500 > @@ -257,7 +257,7 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np); > > =A0 =A0 =A0 =A0/* try the deprecated version */ > - =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar"); > + =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar") > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np); > > =A0 =A0 =A0 =A0return 0; > --- > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [stable] [PATCH] powerpc: Remove extra semicolon in fsl_soc.c 2009-03-11 16:03 ` Grant Likely @ 2009-03-11 16:05 ` Greg KH 2009-03-13 6:03 ` Greg KH 1 sibling, 0 replies; 4+ messages in thread From: Greg KH @ 2009-03-11 16:05 UTC (permalink / raw) To: Grant Likely; +Cc: linuxppc-dev, Greg KH, Johns Daniel, afleming, stable On Wed, Mar 11, 2009 at 10:03:22AM -0600, Grant Likely wrote: > On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrote: > > A semicolon at the end of the macro means that the for loop has an > > empty body, and so TSEC/MDIO will not work with older device trees. > > > > This fix only applies to 2.6.28; apparently, this code is gone for > > 2.6.29, according to Grant Likely! > > > > Signed-off-by: Johns Daniel <johns.daniel@gmail.com> > > Acked-by: Grant Likely <grant.likely@secretlab.ca> > > Greg: Andy Flemming should probably confirm this, but I think this > one should be backported to the stable series. That's what he is asking for as he sent it to stable@kernel.org and asked that it go into the 2.6.28 tree only :) thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c 2009-03-11 16:03 ` Grant Likely 2009-03-11 16:05 ` [stable] " Greg KH @ 2009-03-13 6:03 ` Greg KH 1 sibling, 0 replies; 4+ messages in thread From: Greg KH @ 2009-03-13 6:03 UTC (permalink / raw) To: Grant Likely; +Cc: afleming, Greg KH, Johns Daniel, stable, linuxppc-dev On Wed, Mar 11, 2009 at 10:03:22AM -0600, Grant Likely wrote: > On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrote: > > A semicolon at the end of the macro means that the for loop has an > > empty body, and so TSEC/MDIO will not work with older device trees. > > > > This fix only applies to 2.6.28; apparently, this code is gone for > > 2.6.29, according to Grant Likely! > > > > Signed-off-by: Johns Daniel <johns.daniel@gmail.com> > > Acked-by: Grant Likely <grant.likely@secretlab.ca> > > Greg: Andy Flemming should probably confirm this, but I think this > one should be backported to the stable series. Hm, this patch is line-wrapped and tabs are stripped, so I can't apply it :( Anyone care to resend it? thanks, greg k-h > > --- > > --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig 2009-02-20 > > 16:41:27.000000000 -0600 > > +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c 2009-03-10 > > 15:56:47.000000000 -0500 > > @@ -257,7 +257,7 @@ > > gfar_mdio_of_init_one(np); > > > > /* try the deprecated version */ > > - for_each_compatible_node(np, "mdio", "gianfar"); > > + for_each_compatible_node(np, "mdio", "gianfar") > > gfar_mdio_of_init_one(np); > > > > return 0; > > --- > > _______________________________________________ > > Linuxppc-dev mailing list > > Linuxppc-dev@ozlabs.org > > https://ozlabs.org/mailman/listinfo/linuxppc-dev > > > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-13 6:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-03-11 15:50 [PATCH] powerpc: Remove extra semicolon in fsl_soc.c Johns Daniel 2009-03-11 16:03 ` Grant Likely 2009-03-11 16:05 ` [stable] " Greg KH 2009-03-13 6:03 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).