From: Grant Likely <grant.likely@secretlab.ca>
To: jdaniel@computer.org
Cc: greg@kroah.com, afleming@freescale.com, stable@kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try)
Date: Sat, 14 Mar 2009 20:01:42 -0600 [thread overview]
Message-ID: <fa686aa40903141901jc25836dne554e14182e35dfd@mail.gmail.com> (raw)
In-Reply-To: <49BBC757.7090001@computer.org>
On Sat, Mar 14, 2009 at 9:03 AM, Johns Daniel <jdaniel@computer.org> wrote:
> TSEC/MDIO will not work with older device trees because of a semicolon at
> the end of a macro resulting in an empty for loop body.
>
> This fix only applies to 2.6.28; this code is gone in 2.6.29, according t=
o
> Grant Likely!
>
> Signed-off-by: Johns Daniel <johns.daniel@gmail.com
> <mailto:johns.daniel@gmail.com>>
Your signed-off-by line is odd. I assume your mailer did this to you.
But in case Greg picks it up anyway:
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig =A0 2009-02-20
> 16:41:27.000000000 -0600
> +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c =A0 =A0 =A0 =A02009-03-1=
4
> 09:01:38.994630400 -0500
> @@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
>
> =A0 =A0 =A0 =A0/* try the deprecated version */
> - =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar");
> + =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar")
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
>
> =A0 =A0 =A0 =A0return 0;
>
>
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2009-03-15 2:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 15:03 [PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try) Johns Daniel
2009-03-15 2:01 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40903141901jc25836dne554e14182e35dfd@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=afleming@freescale.com \
--cc=greg@kroah.com \
--cc=jdaniel@computer.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).