Re: [RFC]PPC driver lock for DMA registers

[Grant Likely <grant.likely@secretlab.ca>]

On Wed, Mar 18, 2009 at 10:29 AM, Eddie Dawydiuk <eddie@embeddedarm.com> wrote:
> Hello,
>
> I'm working on SD card and Nand drivers that I would like to eventually
> submit for inclusion in the mainline kernel. This being my first kernel port
> being submitted upstream I was hoping for comments on my proposed design to
> ensure it would be excepted in the mainline kernel(from a design
> standpoint). We have an FPGA on our product that has an interface for
> transferring data via DMA. The SD card driver and Nand flash driver will
> both be accessing these registers. As a result I was planning on writing a
> dma driver(drivers/dma/ts81xx.c) that implements a function dma_op() that
> gets passed a physical address, virtual address, length, and read/write op
> and returns an int. I'd use a semaphore to protect the registers. I'd also
> implement a function dma_bus_init() for allocating a cache coherent buffer,
> initializing the semaphore, and ioremapping the FPGA regs.

Nothing that you describe here sounds off base, but the proof is in
the pudding so they say.  Best advice I can offer is to follow the
example of existing powerpc device drivers.  You'll need to describe
your FPGA interface in the .dts file and write an of_platform driver
that binds against it.  Make sure you post your proposed dts
description of the FPGA to the devicetree-discuss@ozlabs.org mailing
list before committing to it.  In you're device drivers .probe() hook
you would create and register the NAND and SD devices with the kernel
with the needed hooks to access the FPGA.

Here are some good examples of of_platform drivers to look at:

drivers/block/xsysace.c
drivers/spi/xilinx_spi.c
drivers/i2c/busses/i2c-ibm_iic.c

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.