Re: Build error

[Grant Likely <grant.likely@secretlab.ca>]

On Tue, Mar 31, 2009 at 2:41 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko]
>>>>> undefined!
>>>>>
>>>> I believe this is fixed in net-next (and possible linus has already
>>>> pulled that in.)
>>>
>>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next'
>>> branch nor in `merge' branch...
>>
>> Ah .. .weird :-)
>
> I had this happen a few days ago already, on Linus' tree. =A0I also told
> you about it (on IRC), but you were too busy or something :-)
>
> A simple ppc6xx_defconfig is enough to reproduce, fwiw.
>
> Here's the patch I used, sorry if my mailer wraps it, it's a one-liner,
> you can handle it I'm sure :-)
>
> Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>

Heh, you beat me to it Segher.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

g.

>
>
> Author: Segher Boessenkool <segher@kernel.crashing.org>
> Date: =A0 Fri Mar 27 21:10:59 2009 +0100
>
> =A0 =A0powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name)
>
> diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
> index b3079a5..a108332 100644
> --- a/drivers/net/fsl_pq_mdio.c
> +++ b/drivers/net/fsl_pq_mdio.c
> @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct device_n=
ode
> *np
> =A0 =A0 =A0 =A0snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(unsigned long long)taddr);
> =A0}
> +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name);
>
> =A0/* Scan the bus in reverse, looking for an empty spot */
> =A0static int fsl_pq_mdio_find_free(struct mii_bus *new_bus)
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>



--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.