* Build error @ 2009-03-30 3:25 Benjamin Herrenschmidt 2009-03-30 13:51 ` Kumar Gala 0 siblings, 1 reply; 8+ messages in thread From: Benjamin Herrenschmidt @ 2009-03-30 3:25 UTC (permalink / raw) To: Kumar Gala; +Cc: linuxppc-dev list My next branch (after merging from you): ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] undefined! I'll ask Linus to pull anyway though. Cheers, Ben. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-30 3:25 Build error Benjamin Herrenschmidt @ 2009-03-30 13:51 ` Kumar Gala 2009-03-30 13:59 ` Anton Vorontsov 0 siblings, 1 reply; 8+ messages in thread From: Kumar Gala @ 2009-03-30 13:51 UTC (permalink / raw) To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list On Mar 29, 2009, at 10:25 PM, Benjamin Herrenschmidt wrote: > My next branch (after merging from you): > > ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] > undefined! > > I'll ask Linus to pull anyway though. > > Cheers, > Ben. I believe this is fixed in net-next (and possible linus has already pulled that in.) - k ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-30 13:51 ` Kumar Gala @ 2009-03-30 13:59 ` Anton Vorontsov 2009-03-30 23:18 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 8+ messages in thread From: Anton Vorontsov @ 2009-03-30 13:59 UTC (permalink / raw) To: Kumar Gala; +Cc: linuxppc-dev list On Mon, Mar 30, 2009 at 08:51:38AM -0500, Kumar Gala wrote: > > On Mar 29, 2009, at 10:25 PM, Benjamin Herrenschmidt wrote: > >> My next branch (after merging from you): >> >> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] >> undefined! >> >> I'll ask Linus to pull anyway though. >> >> Cheers, >> Ben. > > I believe this is fixed in net-next (and possible linus has already > pulled that in.) FWIW, I can't reproduce the issue neither in benh/powerpc.git `next' branch nor in `merge' branch... -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-30 13:59 ` Anton Vorontsov @ 2009-03-30 23:18 ` Benjamin Herrenschmidt 2009-03-31 20:41 ` Segher Boessenkool 2009-03-31 20:52 ` Grant Likely 0 siblings, 2 replies; 8+ messages in thread From: Benjamin Herrenschmidt @ 2009-03-30 23:18 UTC (permalink / raw) To: avorontsov; +Cc: linuxppc-dev list On Mon, 2009-03-30 at 17:59 +0400, Anton Vorontsov wrote: > On Mon, Mar 30, 2009 at 08:51:38AM -0500, Kumar Gala wrote: > > > > On Mar 29, 2009, at 10:25 PM, Benjamin Herrenschmidt wrote: > > > >> My next branch (after merging from you): > >> > >> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] > >> undefined! > >> > >> I'll ask Linus to pull anyway though. > >> > >> Cheers, > >> Ben. > > > > I believe this is fixed in net-next (and possible linus has already > > pulled that in.) > > FWIW, I can't reproduce the issue neither in benh/powerpc.git `next' > branch nor in `merge' branch... Ah .. .weird :-) Oh well, I'll see if it still happens after I pull back from Linus (who merged all our stuff) and if it does, I'll send you my .config. Cheers, Ben. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-30 23:18 ` Benjamin Herrenschmidt @ 2009-03-31 20:41 ` Segher Boessenkool 2009-03-31 20:54 ` Grant Likely 2009-03-31 20:57 ` Anton Vorontsov 2009-03-31 20:52 ` Grant Likely 1 sibling, 2 replies; 8+ messages in thread From: Segher Boessenkool @ 2009-03-31 20:41 UTC (permalink / raw) To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list >>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] >>>> undefined! >>>> >>>> I'll ask Linus to pull anyway though. >>>> >>>> Cheers, >>>> Ben. >>> >>> I believe this is fixed in net-next (and possible linus has already >>> pulled that in.) >> >> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next' >> branch nor in `merge' branch... > > Ah .. .weird :-) I had this happen a few days ago already, on Linus' tree. I also told you about it (on IRC), but you were too busy or something :-) A simple ppc6xx_defconfig is enough to reproduce, fwiw. Here's the patch I used, sorry if my mailer wraps it, it's a one-liner, you can handle it I'm sure :-) Segher Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org> Author: Segher Boessenkool <segher@kernel.crashing.org> Date: Fri Mar 27 21:10:59 2009 +0100 powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name) diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c index b3079a5..a108332 100644 --- a/drivers/net/fsl_pq_mdio.c +++ b/drivers/net/fsl_pq_mdio.c @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct device_node *np snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name, (unsigned long long)taddr); } +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name); /* Scan the bus in reverse, looking for an empty spot */ static int fsl_pq_mdio_find_free(struct mii_bus *new_bus) ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-31 20:41 ` Segher Boessenkool @ 2009-03-31 20:54 ` Grant Likely 2009-03-31 20:57 ` Anton Vorontsov 1 sibling, 0 replies; 8+ messages in thread From: Grant Likely @ 2009-03-31 20:54 UTC (permalink / raw) To: Segher Boessenkool; +Cc: David Miller, linuxppc-dev list On Tue, Mar 31, 2009 at 2:41 PM, Segher Boessenkool <segher@kernel.crashing.org> wrote: >>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] >>>>> undefined! >>>>> >>>> I believe this is fixed in net-next (and possible linus has already >>>> pulled that in.) >>> >>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next' >>> branch nor in `merge' branch... >> >> Ah .. .weird :-) > > I had this happen a few days ago already, on Linus' tree. =A0I also told > you about it (on IRC), but you were too busy or something :-) > > A simple ppc6xx_defconfig is enough to reproduce, fwiw. > > Here's the patch I used, sorry if my mailer wraps it, it's a one-liner, > you can handle it I'm sure :-) > > Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org> Heh, you beat me to it Segher. Acked-by: Grant Likely <grant.likely@secretlab.ca> g. > > > Author: Segher Boessenkool <segher@kernel.crashing.org> > Date: =A0 Fri Mar 27 21:10:59 2009 +0100 > > =A0 =A0powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name) > > diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c > index b3079a5..a108332 100644 > --- a/drivers/net/fsl_pq_mdio.c > +++ b/drivers/net/fsl_pq_mdio.c > @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct device_n= ode > *np > =A0 =A0 =A0 =A0snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(unsigned long long)taddr); > =A0} > +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name); > > =A0/* Scan the bus in reverse, looking for an empty spot */ > =A0static int fsl_pq_mdio_find_free(struct mii_bus *new_bus) > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-31 20:41 ` Segher Boessenkool 2009-03-31 20:54 ` Grant Likely @ 2009-03-31 20:57 ` Anton Vorontsov 1 sibling, 0 replies; 8+ messages in thread From: Anton Vorontsov @ 2009-03-31 20:57 UTC (permalink / raw) To: Segher Boessenkool; +Cc: linuxppc-dev list On Tue, Mar 31, 2009 at 10:41:38PM +0200, Segher Boessenkool wrote: >>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] >>>>> undefined! >>>>> >>>>> I'll ask Linus to pull anyway though. >>>>> >>>>> Cheers, >>>>> Ben. >>>> >>>> I believe this is fixed in net-next (and possible linus has already >>>> pulled that in.) >>> >>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next' >>> branch nor in `merge' branch... >> >> Ah .. .weird :-) > > I had this happen a few days ago already, on Linus' tree. I also told > you about it (on IRC), but you were too busy or something :-) > > A simple ppc6xx_defconfig is enough to reproduce, fwiw. > > Here's the patch I used, sorry if my mailer wraps it, it's a one-liner, > you can handle it I'm sure :-) Ah, the modular build. Yeah, I didn't try it, but should have... :-( Thanks! > Segher > > > Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org> > > > Author: Segher Boessenkool <segher@kernel.crashing.org> > Date: Fri Mar 27 21:10:59 2009 +0100 > > powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name) > > diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c > index b3079a5..a108332 100644 > --- a/drivers/net/fsl_pq_mdio.c > +++ b/drivers/net/fsl_pq_mdio.c > @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct > device_node *np > snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name, > (unsigned long long)taddr); > } > +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name); > > /* Scan the bus in reverse, looking for an empty spot */ > static int fsl_pq_mdio_find_free(struct mii_bus *new_bus) > -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Build error 2009-03-30 23:18 ` Benjamin Herrenschmidt 2009-03-31 20:41 ` Segher Boessenkool @ 2009-03-31 20:52 ` Grant Likely 1 sibling, 0 replies; 8+ messages in thread From: Grant Likely @ 2009-03-31 20:52 UTC (permalink / raw) To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list, David Miller On Mon, Mar 30, 2009 at 5:18 PM, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Mon, 2009-03-30 at 17:59 +0400, Anton Vorontsov wrote: >> On Mon, Mar 30, 2009 at 08:51:38AM -0500, Kumar Gala wrote: >> > >> > On Mar 29, 2009, at 10:25 PM, Benjamin Herrenschmidt wrote: >> > >> >> My next branch (after merging from you): >> >> >> >> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko] >> >> undefined! >> >> >> >> I'll ask Linus to pull anyway though. >> >> >> >> Cheers, >> >> Ben. >> > >> > I believe this is fixed in net-next (and possible linus has already >> > pulled that in.) >> >> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next' >> branch nor in `merge' branch... > > Ah .. .weird :-) > > Oh well, I'll see if it still happens after I pull back from Linus (who > merged all our stuff) and if it does, I'll send you my .config. It is triggered when the driver is built as a module. I'm going to post the fix right now. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-03-31 20:57 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-03-30 3:25 Build error Benjamin Herrenschmidt 2009-03-30 13:51 ` Kumar Gala 2009-03-30 13:59 ` Anton Vorontsov 2009-03-30 23:18 ` Benjamin Herrenschmidt 2009-03-31 20:41 ` Segher Boessenkool 2009-03-31 20:54 ` Grant Likely 2009-03-31 20:57 ` Anton Vorontsov 2009-03-31 20:52 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).