From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <49DC4F4D.10803@grandegger.com> References: <20090407082052.477328750@denx.de> <20090407082231.803193635@denx.de> <49DC4F4D.10803@grandegger.com> From: Grant Likely Date: Wed, 8 Apr 2009 07:53:22 -0700 Message-ID: Subject: Re: [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board To: Wolfgang Grandegger Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org, linux-i2c@vger.kernel.org, Ben Dooks List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Apr 8, 2009 at 12:16 AM, Wolfgang Grandegger wr= ote: > Grant Likely wrote: >> On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger = wrote: >>> Preserve I2C clock settings for the Socrates MPC8544 board. >> >> I had thought that the preserve-clocking property was intended for >> older boards that don't currently have any method of getting the clock >> setting out of u-boot. =A0Since Socrates is a new board, U-Boot should >> probably be made to fill in the real clock rate setting. > > I'm not sure if I understand what you mean. If an old version of U-Boot > on an old board sets the I2C clock, it can be used (inherited) by Linux > using the property "preserve-clocking". > > It is actually the customers choice to set the I2C clock in U-Boot and > re-use it by Linux. Setting it in the register !=3D recording the value in the device tree. I'm saying that since Socrates is a new board it should not use the preserve-clocking dirty trick (and it is a dirty trick) because the correct clocking data can be passed via the device tree. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.