From: Grant Likely <grant.likely@secretlab.ca>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, Eddie Dawydiuk <eddie@embeddedarm.com>
Subject: Re: AMCC 440EP phy detection
Date: Wed, 8 Apr 2009 10:00:30 -0700 [thread overview]
Message-ID: <fa686aa40904081000x2dbdd417y149fe442b9fc55bf@mail.gmail.com> (raw)
In-Reply-To: <200904081801.27754.sr@denx.de>
On Wed, Apr 8, 2009 at 9:01 AM, Stefan Roese <sr@denx.de> wrote:
> On Wednesday 08 April 2009, Eddie Dawydiuk wrote:
>> > I found the ibm_newemac driver(2.6.29) makes the assumption that the
>> > bootloader has already configured the tx enable pin as it is a
>> > multiplexed pin. Unfortuantley I am not using U-Boot and our minimal
>> > bootloader does not do this. =A0After finding tx enable was never
>> > asserting for Eth0 a quick user space program verified tx enable was
>> > configured as a GPIO pin.
>>
>> I would like to eventually submit our changes for upstream support. Base=
d
>> on this would you recommend ensuring tx enable is configured properly in
>> the initialization of the ibm_newemac driver or the platform
>> initialization?
>
> This GPIO multiplexing configuration does not belong into the ibm_newemac
> driver since it is very platform/board specific. The platform code is
> definitely a better place.
Even better is the platform specific boot code (firmware or equivalent)
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-04-08 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 16:32 AMCC 440EP phy detection Eddie Dawydiuk
2009-04-07 16:47 ` Feng Kan
2009-04-07 18:20 ` Eddie Dawydiuk
2009-04-07 17:11 ` Grant Likely
2009-04-07 17:18 ` Stefan Roese
2009-04-08 0:10 ` Eddie Dawydiuk
2009-04-08 15:47 ` Eddie Dawydiuk
2009-04-08 16:01 ` Stefan Roese
2009-04-08 17:00 ` Grant Likely [this message]
2009-04-08 18:19 ` Stefan Roese
2009-04-08 18:35 ` Eddie Dawydiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40904081000x2dbdd417y149fe442b9fc55bf@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=eddie@embeddedarm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).