From: Grant Likely <grant.likely@secretlab.ca>
To: Feng Kan <fkan@amcc.com>
Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] Added AMCC 460EX Canyonlands SATA support.
Date: Fri, 1 May 2009 15:35:23 -0600 [thread overview]
Message-ID: <fa686aa40905011435v1071f871nbc47871fdb4046e1@mail.gmail.com> (raw)
In-Reply-To: <1241211774-32719-1-git-send-email-fkan@amcc.com>
On Fri, May 1, 2009 at 3:02 PM, Feng Kan <fkan@amcc.com> wrote:
> This adds the OF platform support for the AMCC 460EX Canyonlands SATA por=
t.
>
> Signed-off-by: Feng Kan <fkan@amcc.com>
> ---
> =A0arch/powerpc/boot/dts/canyonlands.dts =A0| =A0 =A08 ++
> =A0arch/powerpc/platforms/44x/Makefile =A0 =A0| =A0 =A04 +
> =A0arch/powerpc/platforms/44x/amcc-sata.c | =A0125 ++++++++++++++++++++++=
++++++++++
> =A03 files changed, 137 insertions(+), 0 deletions(-)
> =A0create mode 100644 arch/powerpc/platforms/44x/amcc-sata.c
>
> diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dt=
s/canyonlands.dts
> index 5fd1ad0..b536223 100644
> --- a/arch/powerpc/boot/dts/canyonlands.dts
> +++ b/arch/powerpc/boot/dts/canyonlands.dts
> @@ -163,6 +163,14 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <0x1e 4>;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 };
>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0SATA0: sata@bffd1000 {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0compatible =3D "amcc,sat=
a-460ex";
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <4 0xbffd1000 0x800=
4 0xbffd0800 0x400>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0interrupt-parent =3D <&U=
IC3>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0interrupts =3D <0 4 =A0 =
=A0 =A0 /* SATA */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A05 4>; =A0 =A0 /* AHBDMA */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0};
> +
You should also add documentation for the "amcc,sata-460ex" binding to
Documentation/powerpc/dts-bindings. Doesn't have to be huge, just a
blurb describing the device and what each tuple in the reg &
interrupts properties mean.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-01 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 21:02 [PATCH 2/2] Added AMCC 460EX Canyonlands SATA support Feng Kan
2009-05-01 21:35 ` Grant Likely [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-29 21:42 Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905011435v1071f871nbc47871fdb4046e1@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=fkan@amcc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox