From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
Vitaly Bordug <vbordug@ru.mvista.com>
Subject: Re: [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'
Date: Fri, 8 May 2009 09:55:31 -0600 [thread overview]
Message-ID: <fa686aa40905080855g1b24b9f4s7a78ccb75b5be8b1@mail.gmail.com> (raw)
In-Reply-To: <1241791201-23960-1-git-send-email-w.sang@pengutronix.de>
On Fri, May 8, 2009 at 8:00 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> Initialize the irq-table with PHY_POLL. '-1' means the same now, but is
> hardly maintainable.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Vitaly Bordug <vbordug@ru.mvista.com>
> Cc: Pantelis Antoniou <pantelis.antoniou@gmail.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: netdev@vger.kernel.org
> Cc: linuxppc-dev@ozlabs.org
> ---
> =A0drivers/net/fs_enet/mii-fec.c | =A0 =A02 +-
> =A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.=
c
> index 28077cc..9eb5480 100644
> --- a/drivers/net/fs_enet/mii-fec.c
> +++ b/drivers/net/fs_enet/mii-fec.c
> @@ -166,7 +166,7 @@ static int __devinit fs_enet_mdio_probe(struct of_dev=
ice *ofdev,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto out_unmap_regs;
>
> =A0 =A0 =A0 =A0for (i =3D 0; i < PHY_MAX_ADDR; i++)
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 new_bus->irq[i] =3D -1;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 new_bus->irq[i] =3D PHY_POLL;
This code no longer exists in net-next.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-08 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 14:00 [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1' Wolfram Sang
2009-05-08 15:55 ` Grant Likely [this message]
2009-05-08 16:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905080855g1b24b9f4s7a78ccb75b5be8b1@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox