From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Roderick Colenbrander <thunderbird2k@gmail.com>,
John Linn <linnj@xilinx.com>
Subject: Re: Musings on PCI busses
Date: Tue, 19 May 2009 10:30:39 -0600 [thread overview]
Message-ID: <fa686aa40905190930h54d22e2fj9c9cd4c9911aa485@mail.gmail.com> (raw)
In-Reply-To: <20090519162511.7454D17E8058@mail19-dub.bigfish.com>
On Tue, May 19, 2009 at 10:25 AM, Stephen Neuendorffer
<stephen.neuendorffer@xilinx.com> wrote:
>
>> 1) Probe the host controller in an of_platform driver. =A0This has the
>> advantage of simplicity. =A0The probe routine will get automatically
>> called when the PCI host controller device tree node is registered
>> with the of_platform bus. =A0The bus parenthood also gets reflected in
>> the device model and sysfs. =A0The disadvantage is that it defers PCI
>> bus probing until after the of_platform bus is probed (maybe this is
>> okay; maybe this already happens anyway).
>>
>> 2) Probe the host controller in an subsys_initcall(). =A0Advantage is
>> PCI can be probed earlier in the init path. =A0Disadvantages (minor) are
>> that it will always get called if the driver is enabled, and it needs
>> to manually search the device tree for PCI nodes.
>>
>> I'm leaning towards making it an of_platform driver. =A0Doing so also
>> makes it available to other powerpc processors (not just virtex) in
>> the case where a Xilinx FPGA is welded up to a discrete SoC and a host
>> controller instance is put into the FPGA. =A0(one of those weird things
>> people do when they have an FPGA in their system).
>
> I agree that something is called for... =A0The first might be slightly
> simpler, since it would probably transparently deal with the presence
> of more than one PLB->PCI bridge?
Yes, I think so.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-19 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 15:28 Musings on PCI busses Grant Likely
2009-05-19 16:12 ` Arnd Bergmann
2009-05-19 19:05 ` David Miller
2009-05-19 20:02 ` Grant Likely
2009-05-20 5:33 ` Benjamin Herrenschmidt
2009-05-19 16:25 ` Stephen Neuendorffer
2009-05-19 16:30 ` Grant Likely [this message]
2009-05-20 3:02 ` Benjamin Herrenschmidt
2009-05-20 3:17 ` Grant Likely
2009-05-20 5:31 ` Benjamin Herrenschmidt
2009-05-20 3:01 ` Benjamin Herrenschmidt
2009-05-20 5:51 ` David Miller
2009-05-20 6:51 ` Benjamin Herrenschmidt
2009-05-20 19:24 ` David Miller
2009-05-20 20:06 ` Grant Likely
2009-05-20 21:59 ` Benjamin Herrenschmidt
2009-05-20 22:28 ` Grant Likely
2009-05-20 22:41 ` David Miller
2009-05-20 22:49 ` Benjamin Herrenschmidt
2009-05-20 21:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905190930h54d22e2fj9c9cd4c9911aa485@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linnj@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=stephen.neuendorffer@xilinx.com \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).