Re: powerpc: DMA coherent allocations broken for CONFIG_NOT_COHERENT_CACHE

[Grant Likely <grant.likely@secretlab.ca>]

On Sun, May 24, 2009 at 10:33 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> This is going to .30 if nobody hollers. I've done some testing here
> and it seems to be fine, but more eyes at this stage are much welcome.

Looks okay to me; but I'm not an expert in this area.  Boots fine on
Xilinx Virtex 440 and MPC5200.  One minor nit below.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

> +#ifdef CONFIG_PPC32
> + =A0 =A0 =A0 printk(KERN_INFO "Kernel virtual memory layout:\n");
> + =A0 =A0 =A0 printk(KERN_INFO " =A0* 0x%08lx..0x%08lx =A0: fixmap\n",
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0FIXADDR_START, FIXADDR_TOP);
> +#ifdef CONFIG_HIGHMEM
> + =A0 =A0 =A0 printk(KERN_INFO " =A0* 0x%08lx..0x%08lx =A0: highmem PTEs\=
n",
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0PKMAP_BASE, PKMAP_ADDR(LAST_PKMAP));
> +#endif /* CONFIG_HIGHMEM */
> +#ifdef CONFIG_NOT_COHERENT_CACHE
> + =A0 =A0 =A0 printk(KERN_INFO " =A0* 0x%08lx..0x%08lx =A0: consistent me=
m\n",
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0IOREMAP_TOP, IOREMAP_TOP + CONFIG_CONSISTENT=
_SIZE);
> +#endif /* CONFIG_NOT_COHERENT_CACHE */
> + =A0 =A0 =A0 printk(KERN_INFO " =A0* 0x%08lx..0x%08lx =A0: early ioremap=
\n",
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0ioremap_bot, IOREMAP_TOP);
> + =A0 =A0 =A0 printk(KERN_INFO " =A0* 0x%08lx..0x%08lx =A0: vmalloc & ior=
emap\n",
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0VMALLOC_START, VMALLOC_END);
> +#endif /* CONFIG_PPC32 */

NIT: pr_info().  Same goes for other printk's in this patch.

It would also be nice for comprehension if the file move and the
modification were separate commits.  As it is I had to generate the
diff manually, but I'm not concerned.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.