From: Grant Likely <grant.likely@secretlab.ca>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
timur@freescale.com
Subject: Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
Date: Tue, 26 May 2009 10:56:03 -0600 [thread overview]
Message-ID: <fa686aa40905260956i6fc138f8x87250ceeb8385f6f@mail.gmail.com> (raw)
In-Reply-To: <9e4733910905260953i6337f8a9xc3cd1ff490cd3540@mail.gmail.com>
On Tue, May 26, 2009 at 10:53 AM, Jon Smirl <jonsmirl@gmail.com> wrote:
> On Tue, May 26, 2009 at 12:51 PM, Grant Likely
> <grant.likely@secretlab.ca> wrote:
>> On Tue, May 26, 2009 at 5:01 AM, Mark Brown
>> <broonie@opensource.wolfsonmicro.com> wrote:
>>> On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote:
>>>> Rewrite the mpc5200 audio DMA code to support both I2S and AC97.
>>>>
>>>> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
>>>
>>> Grant, I'm OK with that if you are?
>>
>> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>
> Put in the V5 version this one has this in the h file:
>
> -int psc_dma_trigger(struct snd_pcm_substream *substream, int cmd,
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct snd_soc_dai *=
dai);
> +/* whack this after Timur's patch is merged in to
> arch/powerpc/include/asm/delay.h */
> +#define spin_event_timeout(condition, timeout, delay, rc) =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 \
> +{ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A0 \
> + =A0 =A0 =A0 unsigned long __loops =3D tb_ticks_per_usec * timeout; =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0\
> + =A0 =A0 =A0 unsigned long __start =3D get_tbl(); =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> + =A0 =A0 =A0 while ((rc =3D (condition)) && (tb_ticks_since(__start) <=
=3D __loops)) \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (delay) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 udelay(delay); =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 else =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
\
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cpu_relax(); =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> +}
> +/* whack this after Timur's patch is merged in to
> arch/powerpc/include/asm/delay.h */
sure, no problem if it will grease the merge.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-26 16:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 22:15 [PATCH V4 0/5] AC97 driver for mpc5200 Jon Smirl
2009-05-25 22:15 ` [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value Jon Smirl
2009-05-26 7:29 ` Geert Uytterhoeven
2009-05-26 11:32 ` Timur Tabi
2009-05-26 11:51 ` Geert Uytterhoeven
2009-05-26 12:49 ` Arnd Bergmann
2009-05-26 14:20 ` Timur Tabi
2009-05-25 22:15 ` [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-26 11:01 ` [alsa-devel] " Mark Brown
2009-05-26 16:51 ` Grant Likely
2009-05-26 16:53 ` Jon Smirl
2009-05-26 16:56 ` Grant Likely [this message]
2009-05-26 17:08 ` Timur Tabi
2009-05-26 20:21 ` Mark Brown
2009-05-25 22:15 ` [PATCH V4 3/5] AC97 driver for mpc5200 Jon Smirl
2009-05-26 3:41 ` [alsa-devel] " Timur Tabi
2009-05-26 3:47 ` Grant Likely
2009-05-25 22:15 ` [PATCH V4 4/5] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-25 22:15 ` [PATCH V4 5/5] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-26 3:44 ` [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200 Timur Tabi
2009-05-26 9:21 ` Mark Brown
2009-05-26 11:08 ` Jon Smirl
2009-05-26 11:39 ` Timur Tabi
2009-05-26 11:43 ` Mark Brown
2009-05-26 11:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905260956i6fc138f8x87250ceeb8385f6f@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jonsmirl@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).