From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30]) by ozlabs.org (Postfix) with ESMTP id 30A98DEA99 for ; Wed, 27 May 2009 13:49:53 +1000 (EST) Received: by yx-out-2324.google.com with SMTP id 8so2005555yxb.39 for ; Tue, 26 May 2009 20:49:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20090527002530.16740.62502.stgit@terra> <9e4733910905261744j3589ace8wd427ef8a5998eccf@mail.gmail.com> <9e4733910905261801p130f50afie2c50d5723192d44@mail.gmail.com> From: Grant Likely Date: Tue, 26 May 2009 21:49:32 -0600 Message-ID: Subject: Re: [alsa-devel] [PATCH] Modify mpc5200 AC97 driver to use V9 of spin_event_timeout() To: Timur Tabi Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, broonie@sirena.org.uk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 26, 2009 at 9:12 PM, Timur Tabi wrote: > On Tue, May 26, 2009 at 8:01 PM, Jon Smirl wrote: > >> Then why did you need to make your routine that calls cpu_relax()? > > That gets called only if delay =3D=3D 0. =A0udelay(0) is a no-op, so if t= he > caller specifies no delay, then I need to manually call cpu_relax(). > >> I don't know what goes on in the guts of HMT_low() and cpu_relax(), >> when you guys decide which one I should use let me know and I can >> adjust the patch. > > Grant, I don't see any reason why "udelay(50)" is unacceptable. It's not. See my last email. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.