linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Marcelo Dalmas <m_dalmas@yahoo.com.br>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: Add "mpc5200-simple-platform" to the list of supported boards
Date: Fri, 5 Jun 2009 17:52:56 -0600	[thread overview]
Message-ID: <fa686aa40906051652r2f978065ife1fa71de7f8b5eb@mail.gmail.com> (raw)
In-Reply-To: <461095.11075.qm@web111310.mail.gq1.yahoo.com>

On Fri, Jun 5, 2009 at 5:20 PM, Marcelo Dalmas<m_dalmas@yahoo.com.br> wrote=
:
>
> Hello,
>
> Adding =A0"mpc5200-simple-platform" to the list of supported boards allow=
 to use the option "Generic support for simple MPC5200 based boards" withou=
t patching the kernel. Just set model to "mpc5200-simple-plataform" on your=
 dts file.
>
>
> diff --git a/arch/powerpc/platforms/52xx/mpc5200_simple.c b/arch/powerpc/=
platforms/52xx/mpc5200_simple.c
> index c31e5b5..a2df795 100644
> --- a/arch/powerpc/platforms/52xx/mpc5200_simple.c
> +++ b/arch/powerpc/platforms/52xx/mpc5200_simple.c
> @@ -50,6 +50,7 @@ static void __init mpc5200_simple_setup_arch(void)
>
> =A0/* list of the supported boards */
> =A0static char *board[] __initdata =3D {
> + =A0 =A0 =A0 "mpc5200-simple-platform",
> =A0 =A0 =A0 =A0"intercontrol,digsy-mtc",
> =A0 =A0 =A0 =A0"phytec,pcm030",
> =A0 =A0 =A0 =A0"phytec,pcm032",

Sorry, nack.  For the time being, board support is listed explicitly
in mpc5200_simple.c and 'generic' compatible values are strongly
discouraged.  This is on purpose.

I have been thinking about coming up with a method for generic mpc5200
platform support code to bind against an otherwise unknown mpc5200
board, but there are subtleties here and considerable pain if it is
done wrong.

In the mean time, just patch your kernel with your board name(s) and
don't try to use a generic value like mpc5200-simple-platform.

BTW, please cc: the appropriate maintainers and developers when
posting patches to the Linux kernel.  The MAINTAINERS file and
'scripts/get_maintainer.pl -f <filename>' are useful tools here.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2009-06-05 23:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05 23:20 Add "mpc5200-simple-platform" to the list of supported boards Marcelo Dalmas
2009-06-05 23:52 ` Grant Likely [this message]
2009-06-06  0:28 ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2009-06-05 21:01 Marcelo Dalmas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40906051652r2f978065ife1fa71de7f8b5eb@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m_dalmas@yahoo.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).