From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 5D187B7243 for ; Thu, 18 Jun 2009 06:38:03 +1000 (EST) MIME-Version: 1.0 In-Reply-To: References: <20090611033705.20842.75501.sendpatchset@subratamodak.linux.ibm.com> <1245048719.5239.10.camel@subratamodak.linux.ibm.com> <1245243097.4870.3.camel@subratamodak.linux.ibm.com> <6E26D0A1-0FE5-4179-9DA8-FDF0E3D417DA@kernel.crashing.org> <20090617232341.c4543ff2.sfr@canb.auug.org.au> <20090617233452.03ac78d5.sfr@canb.auug.org.au> From: Grant Likely Date: Wed, 17 Jun 2009 14:37:38 -0600 Message-ID: Subject: Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] To: Stephen Rothwell Content-Type: text/plain; charset=ISO-8859-1 Cc: Sachin P Sant , netdev@vger.kernel.org, Linux-Kernel , Linuxppc-dev , Linux-Next , Nathan Lynch , Haiying Wang , Li Yang , subrata@linux.vnet.ibm.com, "David S. Miller" , Balbir Singh List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 17, 2009 at 11:29 AM, Grant Likely w= rote: > On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell w= rote: >> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell wrote: >>> >>> Hi Kumar, >>> >>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala wrote: >>> > >>> > >>> > I'm confused by the proposed fix as we already have *mdio & *ph >>> > defined in this function: >>> >>> Which tree are you looking at? =A0Linus' tree, and linux-next, do not h= ave >>> those local variables ... >> >> Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework >> ucc_geth driver to use of_mdio infrastructure") removed the locals along >> with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f >> ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses >> without adding the variables back. >> >> Here is the patch again: >> >> From: Subrata Modak >> Subject: [PATCH] Fix build error in ucc_geth.c >> >> Fix the following build error: >> >> drivers/net/ucc_geth.c: In function bucc_geth_probeb: >> drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this f= unction) >> drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is repor= ted only once >> drivers/net/ucc_geth.c:3822: error: for each function it appears in.) >> drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this= function) >> make[2]: *** [drivers/net/ucc_geth.o] Error 1 >> >> Signed-off-by: Subrata Modak >> >> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig =A0 =A0 =A0 =A02009-06-= 10 11:58:39.000000000 -0500 >> +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c =A0 =A0 2009-06-10 22:28:13.= 000000000 -0500 >> @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g >> >> =A0static int ucc_geth_probe(struct of_device* ofdev, const struct of_de= vice_id *match) >> =A0{ >> + =A0 =A0 =A0 struct device_node *mdio; >> + =A0 =A0 =A0 const phandle *ph; >> =A0 =A0 =A0 =A0struct device *device =3D &ofdev->dev; >> =A0 =A0 =A0 =A0struct device_node *np =3D ofdev->node; >> =A0 =A0 =A0 =A0struct net_device *dev =3D NULL; > > Ah, this might not be the right fix then. =A0I'll look. Yeah, this is not the right fix. The SGMII change doesn't mesh well with the of_mdio changes and needed some rewriting. I'm about to post a patch (compile tested only) which should make things happy. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.