From: Grant Likely <grant.likely@secretlab.ca>
To: avorontsov@ru.mvista.com
Cc: spi-devel-general@lists.sourceforge.net,
Rini van Zetten <rini@arvoo.nl>,
linuxppc-dev list <Linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH -mm][POWERPC] mpc8xxx : allow SPI without cs.
Date: Fri, 19 Jun 2009 09:31:33 -0600 [thread overview]
Message-ID: <fa686aa40906190831t2532e978pc1ec647d39e69b8d@mail.gmail.com> (raw)
In-Reply-To: <20090619132501.GA10886@oksana.dev.rtsoft.ru>
On Fri, Jun 19, 2009 at 7:25 AM, Anton
Vorontsov<avorontsov@ru.mvista.com> wrote:
> Surely we can hide the bridge into the SPI controller driver,
> but I think it would be beneficial to "factor-out" it to a
> stand-alone entity, so that other SPI controllers could work
> with this setup without any modifications (oh and btw, we could
> also create a bridge called "gpio-chipselects-bridge", and
> factor out all GPIO stuff from the drivers).
>
> There are two options of how we can factor out chip-select
> machines... the bad and the ugly. :-) No, the first one is bad,
> but the second should be OK.
[...]
> 2. Another option (which I like more), is to create "SPI chip-
> =A0 select machine driver framework", so we could (finally)
> =A0 separate two SPI entities: SPI IO and SPI chip-select machine.
> =A0 CS machines of different flavours: GPIO, built-in, and
> =A0 board-specific (!) with a lot of demuxing magic.
I agree, I think your option 2 is the way to go. It would probably
need to be implemented as some form of logical bridge so that SPI
requests don't go straight to the IO driver, but first go through the
CS machine so that the CS driver can do funky stuff like inserting or
modifying SPI requests before they go to the hardware.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-06-19 15:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 6:19 [PATCH -mm][POWERPC] mpc8xxx : allow SPI without cs Rini van Zetten
2009-06-18 12:42 ` Kumar Gala
2009-06-18 13:09 ` Anton Vorontsov
2009-06-18 14:04 ` Kumar Gala
2009-06-19 7:26 ` [PATCH -mm v3][POWERPC] " Rini van Zetten
2009-06-19 7:45 ` Kumar Gala
2009-06-19 11:16 ` Rini van Zetten
2009-06-19 13:45 ` Anton Vorontsov
2009-06-19 14:18 ` [PATCH -mm v4][POWERPC] " Rini van Zetten
2009-07-03 1:38 ` [spi-devel-general] " David Brownell
2009-06-19 11:45 ` [PATCH -mm][POWERPC] " Leon Woestenberg
2009-06-19 13:25 ` Anton Vorontsov
2009-06-19 15:31 ` Grant Likely [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-11 9:10 [PATCH][POWERPC] mpc83xx " Rini van Zetten
2009-06-11 13:29 ` Kumar Gala
2009-06-12 8:59 ` [PATCH -mm][POWERPC] mpc8xxx " Rini van Zetten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40906190831t2532e978pc1ec647d39e69b8d@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=Linuxppc-dev@ozlabs.org \
--cc=avorontsov@ru.mvista.com \
--cc=rini@arvoo.nl \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).